GitHub user peoplehlj opened a pull request:
https://github.com/apache/cassandra/pull/68
CASSANDRA-11683: Code refactor for StorageServiceMBean.forceRepair* methods
This patch is for https://issues.apache.org/jira/browse/CASSANDRA-11683
For the class StorageServiceMBean, it has below methods,
```
public int forceRepairAsync(String keyspace, boolean isSequential,
Collection<String> dataCenters, Collection<String> hosts, boolean
primaryRange, boolean repairedAt, String... columnFamilies) throws IOException;
public int forceRepairRangeAsync(String beginToken, String endToken, String
keyspaceName, boolean isSequential, Collection<String> dataCenters,
Collection<String> hosts, boolean repairedAt, String... columnFamilies) throws
IOException;
public int forceRepairRangeAsync(String beginToken, String endToken, String
keyspaceName, boolean isSequential, boolean isLocal, boolean repairedAt,
String... columnFamilies);
```
But in the implementation, the arguments are different from this MBean,
please notice the last second argument, from *repairedAt* to *fullRepair*, and
actually *fullRepair* is more clear for this API.
```
public int forceRepairAsync(String keyspace, boolean isSequential,
Collection<String> dataCenters, Collection<String> hosts, boolean primaryRange,
boolean fullRepair, String... columnFamilies) throws IOException{}
public int forceRepairRangeAsync(String beginToken, String endToken, String
keyspaceName, boolean isSequential, Collection<String> dataCenters,
Collection<String> hosts, boolean fullRepair, String... columnFamilies) throws
IOException{}
public int forceRepairRangeAsync(String beginToken, String endToken, String
keyspaceName, boolean isSequential, Collection<String> dataCenters,
Collection<String> hosts, boolean fullRepair, String... columnFamilies) throws
IOException{}
```
This will make developers confused, for example I met an issue that we
didn't want to do a "full" repair but from the MBean I didn't know how to pass
the argument.
Please help to merge it if we want to fix this issue, thanks in advance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peoplehlj/cassandra CASSANDRA-11683
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 4c8b75bc664371c19e118f8497f9777831721084
Author: Huang, Lijun <lijun.hu...@emc.com>
Date: 2016-04-29T09:11:17Z
CASSANDRA-11683: Code refactor for StorageServiceMBean.forceRepair* methods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
