I'll register another (non-binding) -1 due to the failing tests. In particular, CASSANDRA-12651 is due to a legit bug with potential corruption and data loss (albeit in indexes only). The same bug is also the likely cause of CASSANDRA-12590, so it'd be good to include the fix in 3.10.
On Mon, Nov 21, 2016 at 7:27 PM, sankalp kohli <kohlisank...@gmail.com> wrote: > We voted in the dev list discussion[1] that we wont cut a release till all > unit tests are passing. I can see that testall are failing for trunk and > 3.X. Hence I need to do a -1 on this release. My -1 is not due to Dtest > failing as we discussed about unit tests only in that thread. I will start > another thread for making Dtest a blocker for release. > > -1 due to testall failing. > > 1. http://mail-archives.apache.org/mod_mbox/incubator- > cassandra-dev/201607.mbox/%3cCAEPxca1TGo6S1O8DcpM7dmXsBe4 > 4EniSezkpq5_=qksctk3...@mail.gmail.com%3e > > > > On Mon, Nov 21, 2016 at 9:19 AM, Sankalp Kohli <kohlisank...@gmail.com> > wrote: > > > We had decided in an email thread initiated by me that we won't cut > > releases till all tests are passing. > > > > Why not wait till these patches are merged? Is there any critical fix in > > it which need to be rushed out ? > > > > > On Nov 20, 2016, at 23:36, Oleksandr Petrov < > oleksandr.pet...@gmail.com> > > wrote: > > > > > > From just a quick glance, I can say at least some of the tests are > either > > > PA or are getting there: > > > > > > For example: > > > http://cassci.datastax.com/job/cassandra-3.X_novnode_ > > dtest/lastCompletedBuild/testReport/paging_test/ > > TestPagingData/test_paging_with_filtering_on_partition_key/ > > > Should be fixed by > > > https://issues.apache.org/jira/browse/CASSANDRA-12666 > > > > > > http://cassci.datastax.com/job/cassandra-3.X_testall/ > > lastCompletedBuild/testReport/org.apache.cassandra.cql3. > > validation.entities/SecondaryIndexTest/testAllowFilteringOnPartitionK > > eyWithSecondaryIndex/ > > > Should be fixed by > > > https://issues.apache.org/jira/browse/CASSANDRA-12651 > > > > > > Although there can be more tests in PA. > > > > > > On Sun, Nov 20, 2016 at 10:35 PM sankalp kohli <kohlisank...@gmail.com > > > > > wrote: > > > > > >> Hi, > > >> I see the following test runs are failing. Are they for this > release? > > >> > > >> http://cassci.datastax.com/job/cassandra-3.X_utest_cdc/ > > >> http://cassci.datastax.com/job/cassandra-3.X_testall/ > > >> http://cassci.datastax.com/job/cassandra-3.X_offheap_dtest/ > > >> http://cassci.datastax.com/job/cassandra-3.X_novnode_dtest/ > > >> http://cassci.datastax.com/job/cassandra-3.X_dtest/40/ > > >> > > >> Thanks, > > >> Sankalp > > >> > > >> > > >>> On Sun, Nov 20, 2016 at 12:50 PM, Nate McCall <zznat...@gmail.com> > > wrote: > > >>> > > >>> +1 > > >>> > > >>> On Sat, Nov 19, 2016 at 7:08 AM, Michael Shuler < > > mich...@pbandjelly.org> > > >>> wrote: > > >>>> I propose the following artifacts for release as 3.10. > > >>>> > > >>>> sha1: 96d67b109a2ef858c2753bbb9853d01460cb8f8e > > >>>> Git: > > >>>> http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a= > > >>> shortlog;h=refs/tags/3.10-tentative > > >>>> Artifacts: > > >>>> https://repository.apache.org/content/repositories/ > > >>> orgapachecassandra-1135/org/apache/cassandra/apache-cassandra/3.10/ > > >>>> Staging repository: > > >>>> https://repository.apache.org/content/repositories/ > > >>> orgapachecassandra-1135/ > > >>>> > > >>>> The Debian packages are available here: http://people.apache.org/~ > > >>> mshuler > > >>>> > > >>>> The vote will be open for 72 hours (longer if needed). > > >>>> > > >>>> [1]: (CHANGES.txt) https://goo.gl/vah74X > > >>>> [2]: (NEWS.txt) https://goo.gl/In3vp7 > > >>>> > > >>> > > >> > > > -- > > > Alex Petrov > > >
