Inline -- Jeff Jirsa
> On Dec 20, 2017, at 8:38 PM, kurt greaves <k...@instaclustr.com> wrote: > > It would definitely be nice if PR's were made against the actual repo. > Makes commenting/reviewing code a lot easier. I'd say as long as PR's are > kept permanently (after closing) so we can go back and look over > comments/patches would be a big plus. Not a fan of going through JIRA > tickets and finding the linked branches have been deleted. Same > > However not sure about having different identifiers/labels everywhere. > Considering we'll still be creating JIRA tickets it makes sense to me to > use JIRA for labelling/categorisation, and github simply for reviewing > code. Don't really want to go assigning JIRA tickets then have to repeat > the proceduce for github and make sure all labels align. > > Also, if we're adding "closes #123" to commit messages that implies we'll > have "patch by y, reviewed by x for CASSANDRA-XXXX closes #123"? Yes, and we’re already doing that https://github.com/apache/cassandra/commit/db81f6bffef1a8215fec28bb0522dc9684870627 > I don't > know if there is a way to do it (doubtful), but it'd certainly be nice if > JIRA ticket numbers aligned with PR numbers. Not possible as far as I know > >> On 21 December 2017 at 02:56, mck <m...@apache.org> wrote: >> >> >>> There's also no way for us to label, assign or otherwise use PR related >>> features, so I'm really wondering why it would make sense to more >>> heavily using them. >> >> >> Apache does now offer the GitBox service. This makes the github repository >> writable. The asf and github repos are kept in sync, rather than one being >> a mirror of the other. >> >> I'm not entirely sure this would be the right move for C*, given that >> patches and branches are merged in a manner that GitHub pull requests don't >> do (unless you're only committing to trunk). But it would mean PRs can be >> closed otherwise by any of the committers, and to use the reviewers, >> assignees, labels, projects and milestone fields. >> >> Mick. >> >> >> ref: >> - http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache- >> Gitbox-td18273.html >> - https://s3.amazonaws.com/files-dist/AnnualReports/ >> FY2017-ASF-AnnualReport-FINAL.pdf >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org >> For additional commands, e-mail: dev-h...@cassandra.apache.org >> >>
