> My mind set is that by switching to PRs (even if all the conversations are > in JIRA) we can setup automation which helps detect issues before merging.
CircleCI can build github forked branches. AFAIK there's no reason to open a PR. The finer granularity of code review comments can also be on the github commit pages, again you don't need to open the PR (though you will lose any the discussion thread over commits, but i find it easy enough to just reference the previous comment to create the continuity). While PRs are a bit of a headache to close, if you forget to put in the "closes …" text into the commit message then only the author can close it. (I'm not sure if this situation has been improved or not?) regards, Mick --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
