A lot of those methods if I am not wrong have been marked as deprecated in 4.0. So they should not be removed yet, as Jeff mentioned.
The problem I see is that those deprecations have not been mentioned in the deprecation section of the NEWS.txt. As they are MBeans methods, unless people have checked the interface they might not realize that those methods have been deprecated and it might come as a surprise when we remove them. So, we should not remove them but we should mark them as deprecated in the NEWS.txt to. On Thu, Apr 16, 2020 at 12:41 AM Jeff Jirsa <jji...@gmail.com> wrote: > I havent reviewed that code, but it's not surprising there would be > deprecated annotations in a major release. We *SHOULD* be deprecating > things that worked in 3.0/3.11 in 4.0, and removing them in a future > verison. We should only be removing them in 4.0 if they were originally > supported in 2.1/2.2, deprecated in 3.0/3.11, and then become eligible for > removal in 4.0+ > > So of the 30, how many of them are newly deprecated (removal in the future) > vs already deprecated (eligible for removal now)? > > > > On Wed, Apr 15, 2020 at 3:06 PM Stefan Miklosovic < > stefan.mikloso...@instaclustr.com> wrote: > > > Hi, > > > > I was going over StorageServiceMBean and I was quite surprised how > > many deprecated methods there are. Only in that interface itself there > > are 30 deprecation annotations. What is the general feeling about this > > as 4.0 is getting more real? One would say that 4.0 is "breaking > > change" release so I guess that deleting deprecated methods at least > > in these interfaces is worth doing? > > > > Regards > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > >
