.... But it's not merge-than-review, because they've already been reviewed, before being merged to the feature branch, by committers (actually PMC members)?
You want code that's been written by one PMC member and reviewed by 2 other PMC members to be put up for review by some random 4th party? For how long? On Mon, Jan 23, 2023 at 2:54 PM Mick Semb Wever <m...@apache.org> wrote: > The sooner it’s in trunk, the more eyes it will draw, IMO, if you are >> right about most contributors not having paid attention to a feature branch. >> > > > We all agree we want the feature branch incrementally merged sooner rather > than later. > IMHO any merge to trunk, and any rebase and squash of ninja-fix commits, > deserves an invite to reviewers. > Any notion of merge-then-review isn't our community precedent. > > I appreciate the desire to not "be left hanging" by creating a merge > ticket that requires a reviewer when no reviewer shows. And the desire to > move quickly on this. > > I don't object if you wish to use this thread as that review process. On > the other hand, if you create the ticket I promise to be a reviewer of it, > so as not to delay. > > >
