Yes. Great to get this work merged. Thanks to everyone who worked on it and to Ekaterina for leading the charge!
-Jeremiah On Jul 24, 2023 at 9:27:10 PM, C. Scott Andreas <sc...@paradoxica.net> wrote: > Ekaterina, thank you for spearheading JDK17 support for Apache Cassandra! > Exciting to get to this point. > > - Scott > > On Jul 24, 2023, at 7:11 PM, Ekaterina Dimitrova <e.dimitr...@gmail.com> > wrote: > > > Good news! > After run #1638-39 you should not see anything else failing than > SSLFactory test class. This known issue will be fixed by potentially adding > bounty castle. More info in CASSANDRA-17992 and this netty PR: > https://github.com/netty/netty/issues/10317 > We can probably mark the test class with @Ignore, but knowing how easily > those are forgotten and 17992 being already in review, I prefer not to do > it. > > The only new failure I found in #1636 is a rare flaky test we never saw in > CircleCI before. (unit tests were running only there; they were not enabled > in Jenkins until we cleaned them ). Ticket already opened - > CASSANDRA-18685 <https://issues.apache.org/jira/browse/CASSANDRA-18685> > > Last but not least, eclipse-warnings is already removed (it doesn't work > with post JDK8 versions), but the new static analysis from Checker > Framework is already in review and soon to land in trunk - CASSANDRA-18239 > > As usual - if you have any questions or concerns, please do let me know. > Last but not least - thank you to everyone who helped in one way or > another with this effort!! > > On Mon, 24 Jul 2023 at 16:37, Ekaterina Dimitrova <e.dimitr...@gmail.com> > wrote: > >> Ninja fix was required for Jenkins, new build started #1636 >> >> On Mon, 24 Jul 2023 at 15:42, Ekaterina Dimitrova <e.dimitr...@gmail.com> >> wrote: >> >>> Done! >>> >>> All commits from 18255 are in. >>> The first run to monitor will be in Jenkins #1635 >>> >>> There will be still fixes to be applied for some unit and in-jvm tests >>> that were pending on the drop but I will do it when I see Jenkins kicking >>> in this run properly. (Which are those can be seen in CASSANDRA-16895, >>> there is a table in its description) >>> >>> I will keep you posted on any new developments. >>> >>> >>> On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova <e.dimitr...@gmail.com> >>> wrote: >>> >>>> Starting commits for 18255. Please put on hold any trunk commits. I >>>> will let you know when it is done. Thank you >>>> >>>> On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova < >>>> e.dimitr...@gmail.com> wrote: >>>> >>>>> Hi everyone, >>>>> >>>>> Happy Monday! >>>>> >>>>> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI >>>>> systems today. >>>>> This requires numerous patches in a few repos so you will be seeing >>>>> more failures in CI throughout the day today, but it shouldn’t be anything >>>>> more 🤞 than what we have listed in the table of failures in >>>>> CASSANDRA-16895’s description. I will be applying the fixes one by one >>>>> today. >>>>> I will keep you posted with updates. Also, please, do let me know if >>>>> you have any questions or concerns. >>>>> >>>>> Best regards, >>>>> Ekaterina >>>>> >>>>> >>>>>
