As noted on CASSANDRA-16565 we don't actually need sigar for anything, so I don't see a reason to keep any of it, especially if that is going to force us to specify OSes.
Kind Regards, Brandon On Fri, Oct 20, 2023 at 9:04 AM Claude Warren, Jr via dev <[email protected]> wrote: > > I am looking at https://issues.apache.org/jira/browse/CASSANDRA-18775 and > want to ensure that I do not remove too many libraries. > > I think that preserving any sigar library where the file name contains the > word "linux" or "macosx" should be acceptable. This will preserve: > libsigar-amd64-linux.so > libsigar-ia64-linux.so > libsigar-ppc-linux.so > libsigar-ppc64-aix-5.so > libsigar-ppc64-linux.so > libsigar-ppc64le-linux.so > libsigar-s390x-linux.so > libsigar-universal-macosx.dylib > libsigar-universal64-macosx.dylib > libsigar-x86-linux.so > > and remove: > > libsigar-amd64-freebsd-6.so > libsigar-amd64-solaris.so > libsigar-ia64-hpux-11.sl > libsigar-pa-hpux-11.sl > libsigar-ppc-aix-5.so > libsigar-sparc-solaris.so > libsigar-sparc64-solaris.so > libsigar-x86-freebsd-5.so > libsigar-x86-freebsd-6.so > libsigar-x86-solaris.so > > resulting in a savings of 3,105,384 bytes out of 6,450,526 from the > /lib/sigar-bin directory, a 48% reduction. > > Does anyone see any reason _not_ to do this?
