Only indented items below "sstable" belong to "sstable". It is commented out by default to make it clear that it is not required and the default values apply.
There are a number of sstable parameters which are historically spread across the yaml with no structure. The point is that we should not add to that mess and try to group the new stuff. "default_compression" under ""sstable" key sounds good to me. - - -- --- ----- -------- ------------- Jacek Lewandowski czw., 21 mar 2024 o 08:32 Claude Warren, Jr via dev < dev@cassandra.apache.org> napisał(a): > Jacek, > > I am a bit confused here. I find a key for "sstable" in the yaml but it > is commented out by default. There are a number of options under it that > are commented out and then one that is not and then the > "default_compaction" section, which I assume is supposed to apply to the > "sstable" section. Are you saying that the "sstable_compression" section > that we introduced should be placed as a child to the "sstable" key (and > probably renamed to default_compression"? > > I have included the keys from the trunk yaml below with non-key comments > excluded. The way I read it either the "sstable" key is not required and a > user can just uncomment "column_index_size"; or "column_index_cache_size" > is not really used because it would be under > "sstable/column_index_cache_size" in the Config; or the "sstable:" is only > intended to be a visual break / section for the human editor. > > Can you or someone clarify this form me? > > #sstable: > # selected_format: big > # column_index_size: 4KiB > column_index_cache_size: 2KiB > # default_compaction: > # class_name: SizeTieredCompactionStrategy > # parameters: > # min_threshold: 4 > # max_threshold: 32 > > On Wed, Mar 20, 2024 at 10:31 PM Jacek Lewandowski < > lewandowski.ja...@gmail.com> wrote: > >> Compression params for sstables should be under the "sstable" key. >> >> >> - - -- --- ----- -------- ------------- >> Jacek Lewandowski >> >> >> wt., 19 mar 2024 o 13:10 Ekaterina Dimitrova <e.dimitr...@gmail.com> >> napisał(a): >> >>> Any new settings are expected to be added in the new format >>> >>> On Tue, 19 Mar 2024 at 5:52, Bowen Song via dev < >>> dev@cassandra.apache.org> wrote: >>> >>>> I believe the `foobar_in_kb: 123` format in the cassandra.yaml file is >>>> deprecated, and the new format is `foobar: 123KiB`. Is there a need to >>>> introduce new settings entries with the deprecated format only to be >>>> removed at a later version? >>>> >>>> >>>> On 18/03/2024 14:39, Claude Warren, Jr via dev wrote: >>>> >>>> After much work by several people, I have pulled together the changes >>>> to define the default compression in the cassandra.yaml file and have >>>> created a pull request [1]. >>>> >>>> If you are interested this in topic, please take a look at the changes >>>> and give at least a cursory review. >>>> >>>> [1] https://github.com/apache/cassandra/pull/3168 >>>> >>>> Thanks, >>>> Claude >>>> >>>>
