I would like to vote for banning streams in all non-test code. It may not be easy for new contributors to distinguish between hot path and non-hot path. So would be great if we can simply block them in non-test code and update codestyle to detect the usage.
> On Jun 4, 2024, at 6:26 PM, Josh McKenzie <jmcken...@apache.org> wrote: > > I'm in the "ban in non-test cases, allow in tests" camp. Can sometimes make > things more expressive and concise. > > On Mon, Jun 3, 2024, at 12:07 PM, Sam wrote: >> Added. >> >> Here is the 'after' profile >> >> <image.png> >> >> On Sun, 2 Jun 2024 at 20:50, Mick Semb Wever <m...@apache.org >> <mailto:m...@apache.org>> wrote: >> >> On profiling a 90% write workload I found >> StorageProxy::updateCoordinatorWriteLatencyTableMetric to be a hot-path, >> consuming between 15-20% of ModificationStatement::executeWithoutCondition >> cycles. >> >> https://github.com/apache/cassandra/pull/3344 >> <image.png> >> >> >> Ouch. Ok, I've no idea what constitutes an ok "slow path" now… >> >> Sam, can you also share in the ticket the easy-cass-stress profile you used >> please.
