> This presents an opportune moment for those interested to review the code. > ... > +88,341 −7,341 > 1003 Files changed
O.o This is... **very large**. If we use CASSANDRA-8099 as our "banana for scale": > 645 files changed, 49381 insertions(+), 42227 deletions(-) To be clear - I don't think we collectively should be worried about disruption from this patch since: 1. Each commit (or the vast majority?) has already been reviewed by >= 1 other committer 2. 7.3k deletions is a lot less than 42k 3. We now have fuzzing, property based testing, and the simulator 4. Most of this code is additive How would you recommend interested parties engage with reviewing this behemoth? Or perhaps subsections of it or key areas to familiarize themselves with the structure? On Fri, Sep 20, 2024, at 12:17 PM, David Capwell wrote: > Recently, we rebased against the trunk branch, ensuring that the accord > branch is now in sync with the latest trunk version. This presents an > opportune moment for those interested to review the code. > > > > We have a pending pull request > (_https://github.com/apache/cassandra/pull/3552_) that we do not intend to > merge. > > > > Our current focus is on addressing several bug fixes and ensuring the safety > of topology changes (as evidenced by the number of issues filed against the > trunk). Once we wrap up bug fixes and safety features, we will likely discuss > the merge to trunk, so now is a great time to start engaging. > > > > Thank you everyone for your patience! >
