Yay! Thank you Stefan for the reviews. Looking forward to other reviews on the PR as well from this group. Everytime I learn new things :) Hence I'll keep doing this and I feel great support from the community so why not!
On Fri, Nov 8, 2024 at 1:01 AM Štefan Miklošovič <smikloso...@apache.org> wrote: > Hi, > > I want to highlight this ticket (1) and its older variant here (2) which > is about putting (sensitive) JMX information (passwords etc) to > cassandra.yaml to a new section instead of having them in cassandra-env.sh > (branch here (3)). > > I think it is a good initiative to have all these settings consolidated at > one place in cassandra.yaml, the ticket also says about leaking > sensitive information and in general having all settings, jmx, client & > server options at once place is a good idea. > > If settings are still found in cassandra-env.sh, they are used, instead of > these in cassandra.yaml so old deployments will work without any change. It > is only in case there is nothing in cassandra-env.sh the settings will be > taken from cassandra.yaml. > > Based on the number of watchers this ticket has, (10 and 15 respectively), > it seems to me this is quite a valuable piece of work a lot of people wish > to be delivered. > > I thank a lot to Maulin Vasavada who did this work based on the initial > attempts of others and I provided the first round of reviews for that. The > CI is green and we are comfortable to invite other reviewers in order to > get another binding +1 so we can deliver this (to trunk). > > Regards > > (1) https://issues.apache.org/jira/browse/CASSANDRA-18508 > (2) https://issues.apache.org/jira/browse/CASSANDRA-11695 > (3) https://github.com/apache/cassandra/pull/3638 >
