> Jira actually does that and creates a diagram,
Yes, I am aware about this functionality, unfortunately it does not show
the most interesting part: conditions/expectations for transitions

I have combined the following summary based on comments from Benedict, the
docs and a discussion with Stefan:

*The flow when author is a committer:*
1) In Progress -- an author has attached a patch as MR or patch file -->
Needs Committer (or Patch Available)
2) Needs Committer/Patch Available -- a review is started by other
committers/contributors --> Review in Progress
3) Review in Progress -- some reviewers added comments to address -->
Changes Suggested
4) Changes Suggested -- the author addressed review comments and update the
patch --> Needs Committer/Patch Available
5) Review in Progress -- review comments are addressed; at least one
another committer does a full review and set +1 --> Ready For Commit
6) Ready For Commit -- author or another committer merges the patch to
release branches, update the fix version and commit link --> Resolved

*The flow when author is a contributor (non-committer):*
1) In Progress -- an author has attached a patch as MR or patch file -->
Patch Available
2) Patch Available -- a review is started by other committers/contributors
--> Review in Progress
3) Review in Progress -- some reviewers added comments to address -->
Changes Suggested
4) Changes Suggested -- the author addressed review comments and update the
patch --> Patch Available
5) Review in Progress -- review comments are addressed; at least one
committer does a full review and set +1 --> Needs Committer
6) Needs Committer -- another committer set +1, so in total at least two +1
from committers --> Ready For Commit
6) Ready For Commit -- some committer merges the patch to release branches,
update the fix version and commit link --> Resolved

*Notes:*
1) there is an implicit +1 from the case when author = committer, so in
total - it is always at least two +1 from committers
2) contributors (non-committers) can participate in review but cannot set
binding +1s
3) actual merge can be done by any committer, not necessarily the author or
a reviewer
4) Interim transitions between Patch Available and Resolved can be skipped
by a committer as an author if all quality gates are still passed (+1 is
received, CI results posted, fix version and commit link are updated)

Regards,
Dmitry

On Wed, 29 Jan 2025 at 16:32, Brandon Williams <dri...@gmail.com> wrote:

> On Wed, Jan 29, 2025 at 10:26 AM Dmitry Konstantinov <netud...@gmail.com>
> wrote:
> > I want to draw it explicitly (as a diagram or as a table) and share to
> check my understanding, then after a discussion it can be integrated in the
> contributor docs.
> > I hope it makes sense..
>
> Jira actually does that and creates a diagram, if you look at the
> pinned items in #cassandra-dev on slack there is one that says "The
> great jira workflow map, 9/21" and I have confirmed it's still the
> same today.
>
> Kind Regards,
> Brandon
>


-- 
Dmitry Konstantinov

Reply via email to