> If you want to run check but skip it, it's to add `-Dant.gen-doc.skip=true` I do not think developers have to be forced skip it. Such checks can be a part of CI or merge, but not a common development workflow. It should be in a separate task, and simply calling `ant` should most certainly not invoke it.
Besides, scripts should never implicitly install any third-party software. They may require or depend on some software, or have an option for opt-in installation, but not installing implicitly. On Wed, Apr 23, 2025, at 10:36 PM, Mick Semb Wever wrote: > Python and Go are used by the gen-doc target. > > Code changes can break these, hence it is part of `ant check`. > It is not called by `ant jar` > > If you want to run check but skip it, it's to add `-Dant.gen-doc.skip=true` > > > > On Wed, 23 Apr 2025 at 22:06, Alex Petrov <al...@coffeenco.de> wrote: >> __ >> Hi folks, >> >> Building Cassandra jar has been getting increasingly slow, and now it looks >> like we depend not only on python3 (which was already not optimal), but also >> on go: >> >> ant -Dno-checkstyle=true >> >> ... >> >> [exec] python3 ./scripts/gen-nodetool-docs.py >> [exec] python3 ./scripts/convert_yaml_to_adoc.py ../conf/cassandra.yaml >> ./modules/cassandra/pages/managing/configuration/cass_yaml_file.adoc >> [exec] ./scripts/process-native-protocol-specs-in-docker.sh >> [exec] Go env not found in your system, proceeding with installation. >> [exec] Downloading Go 1.23.1... >> [exec] Installing Go 1.23.1... >> [exec] Building the cqlprotodoc... >> [exec] Cloning into 'cassandra-website'... >> [exec] Your branch is up to date with 'origin/trunk'. >> [exec] go: downloading github.com/mvdan/xurls v1.1.0 >> [exec] Processing the .spec files... >> >> I personally consider this extremely dangerous, but also unnecessary. My >> current stance is that functionality introducing python3 and go should be >> moved to a separate task that only runs on demand / ci / release. I welcome >> convincing arguments that would suggest otherwise. >> >> If you agree we should not require python and go to run `ant >> -Dno-checkstyle=true`, please also write a short message, this will be very >> helpful as well. >> >> Thank you, >> --Alex
