Thanks for the thorough review Bernardo! I'll supply my answers to your comments as I understand things. I would also encourage anybody with more experience in handling ASF licensing/distribution/compat issues than myself to chime in here (since I'm probably wrong on at least some of this).
I would certainly expect the source tarball to include the NOTICE file; this looks like it was just a straight miss when donation happened. The cmurmur3.c file in the repo isn't a straight copy; there are some modifications to the original source. That certainly should be acknowledged (and is acknowledged in the comments at the top of the file) but I'm not sure if that changes any of the calculation around the *requirement* to include this source in LICENSE. At the end of the day, though, it's somewhat academic; to me it seems like the right thing to do is to include an acknowledgement (similar to the one used in Cassandra) in LICENSE to give as much credit as possible. The missing licenses on the four source files is also a straight miss from the work done to bring about the donation. I reviewed that PR and absolutely should have caught this; thanks again for raising it. I will push back a bit on the need for digests around the wheel files. The wheels are binary artifacts and aren't really part of the source build. I include them here for convenience; we don't upload the wheels to PyPi until the vote passes so the inclusion of these files is just a convenience in case reviewers wish to test the 3.31.0 release with the wheels which will eventually go to PyPi. As a result they didn't seem to warrant individual digests. I'll put together a PR to make the changes discussed above. I'm also cancelling this vote for 3.31.0; I'll resubmit after we get these issues completely sorted out. Thanks again to Bernardo! - Bret - On Wed, Nov 18, 2026 at 4:31 AM Bernardo Botella < [email protected]> wrote: > -1 non-binding (I’m not really familiar with python driver, so feel free > to push back on my vote) > > Checked: > - sha1 25393c2e matches tag 3.31.0; pyproject.toml and CHANGELOG.rst are > 3.31.0 > - source tarball: PGP signature (Bret McGuire, B6E8 3A2D 2E44 7E56, in > KEYS) and SHA-256/SHA-512 checksums > - source tarball: all 86 files identical to the tag, no compiled code, > LICENSE present > > Reasons for -1 (licensing, same standard as Cassandra 5.0-alpha1): > - The source tarball has no NOTICE. It is in git, but MANIFEST.in only > includes LICENSE. > Shouldn’t this be inluded? > - cassandra/cmurmur3.c is derived from python-smhasher (MIT, Austin > Appleby / Patrick Hensley), > but LICENSE has no third-party section. Cassandra's LICENSE.txt lists > python-smhasher > after the alpha1 vote; the driver's LICENSE should do the same. > - 4 source files lack a license header: murmur3.py, type_codes.py, > cython_deps.py, asyncioreactor.py > - the 25 wheels have no .asc or .sha256/.sha512 and no NOTICE > > > I think 3.30.1 release has the same issues. So my question is, where those > none before hand and agreed upon? > > Thanks! > Bernardo > > ------------------------------ > *From: *Jane H via dev <[email protected]> > *Date: *Tuesday, 17 November 2026 at 06:38 > *To: *[email protected] <[email protected]> > *Cc: *Jane H <[email protected]> > *Subject: *Re: [VOTE] Release Apache Cassandra Python Driver 3.31.0 > > Non-binding +1. > Verification performed: > 1. Downloaded and verified SHA > 2. Built and ran unit tests with python 3.14 and 3.15 > 3. Ran Apache Airflow (a project that uses cassandra python driver as > dependency in their CI) integration tests with 3.31.0. > > On Mon, Nov 16, 2026 at 1:14 PM Bret McGuire via dev < > [email protected]> wrote: > > Greetings all! I'm proposing the test build of Cassandra Python Driver > 3.31.0 for release. > > > Git commit sha1 for this release: 25393c2e709a353aebb8219c8bfbe60accb7bcc2 > > Git: > *https://github.com/apache/cassandra-python-driver/releases/tag/3.31.0* > <https://github.com/apache/cassandra-python-driver/releases/tag/3.31.0> > > Source release: > > > *https://dist.apache.org/repos/dist/dev/cassandra/cassandra-python-driver/3.31.0/* > <https://dist.apache.org/repos/dist/dev/cassandra/cassandra-python-driver/3.31.0/> > > Changelog: > > > *https://github.com/apache/cassandra-python-driver/blob/3.31.0/CHANGELOG.rst#3310* > <https://github.com/apache/cassandra-python-driver/blob/3.31.0/CHANGELOG.rst#3310> > > > 3.31.0 is a small update to add explicit support for Python 3.15 and drop > support for Python 3.10. Our hope is that this is the last release in the > 3.x line with Python driver 4.0 arriving to replace it. > > > For sake of convenience we’re following roughly the same release process > used for 3.30.1. Wheels for this release can be found in SVN [1]. As a > convenience for testing I've also deployed this release as 3.31.0rc1 [2] on > testpypi [3] . You can install this package from testpypi via the > following sequence of commands: > > > uv pip install deprecated # necessary because transitive dependencies > aren't available on testpypi > > uv pip install --index-url “ <https://test.pypi.org/simple/> > *https://test.pypi.org/simple/* <https://test.pypi.org/simple/>” > cassandra-driver==3.31.0rc1 > > > 3.31.0rc1 follows Python naming conventions [4] for pre-releases. The > content of 3.31.0rc1 is identical to 3.31.0 with the exception of an > additional commit which changes the version. This can be confirmed by > viewing the corresponding tag [5]. > > > The vote will be open for 72 hours (longer if needed) until ~9pm GMT on 19 > November 2026. Everyone who has tested the build is invited to vote. Votes > by PMC members are considered binding. A vote passes if there are at least > three binding +1s and no -1's. > > > Thanks all! > > > - Bret - > > > [1] - > *https://dist.apache.org/repos/dist/dev/cassandra/cassandra-python-driver/3.31.0/wheels/* > <https://dist.apache.org/repos/dist/dev/cassandra/cassandra-python-driver/3.31.0/wheels/> > > [2] - *https://test.pypi.org/project/cassandra-driver/3.31.0rc1/* > <https://test.pypi.org/project/cassandra-driver/3.31.0rc1/> > > [3] - *https://test.pypi.org/* <https://test.pypi.org/> > > [4] - > *https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers* > <https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers> > > [5] - *https://github.com/apache/cassandra-python-driver/tree/3.31.0rc1* > <https://github.com/apache/cassandra-python-driver/tree/3.31.0rc1> > >
