Can you please add below comment to 1173 too and also add that you
successfully tested the patch ;-)
Having said that I agree with you that it don't make sense to
re-marshall the jdoConf at every getDatabase() call. I'll take a look at
this later this evening as I'm refactoring DatabaseRegistry with
CASTOR-1135 ATM.
Ralf
Nick Stuart schrieb:
Yes, it appears to be the same problem. It was trying to load the
configuration because it didnt have a Transaction guy attached to it,
but there was no source to load! :(
Anyways, your path makes more sense as it really does hunt down the
main cause (lack of a transactiondemarcation, but I think another
point is brought up from one of your comments. The fact that we
re-marshall the jdoConf file on EVERY 'getDatabase' call in
JDOConfLoader. I haven't traced this back through the source to see
how often it happens, but it doesn't even really make sense to do it
here.
If we dont have a JdoConf when we call getDatabase then we should
scream about it, not try and parse one hopping its there. Thats what I
though loadConfiguration was there for to begin with.
Thats my 2 US cents.
-Nick
p.s. Is this committed into CVS? If so I'll take a look and see if it
works with no changes by me.
On 7/20/05, Gregory Block <[EMAIL PROTECTED]> wrote:
Bug already filed, patch waiting for someone to comment; though I
tackled it very differently than that. Tell me if that's the same
problem, as I believe it is.
On 20 Jul 2005, at 14:42, Nick Stuart wrote:
Found the problem. In JDOConfLoader in the getDatabase() it calls
loadConfiguration(source, whatever) each time and reloads the file, or
tries to at least. The problem being that if the JDOConfFactory is
used, there is no file to reload, and its null (hence the problem).
Using the Castor-0.9.7 relase I just added the line
if(_jdoConf == null){
....
}
at top of that particular loadConfiguration method. Anyone see this as
a problem? Or has it already been fixed?
-Nick
-------------------------------------------------
If you wish to unsubscribe from this list, please
send an empty message to the following address:
[EMAIL PROTECTED]
-------------------------------------------------
-------------------------------------------------
If you wish to unsubscribe from this list, please
send an empty message to the following address:
[EMAIL PROTECTED]
-------------------------------------------------
-------------------------------------------------
If you wish to unsubscribe from this list, please
send an empty message to the following address:
[EMAIL PROTECTED]
-------------------------------------------------
--
Syscon Ingenieurbüro für
Meß- und Datentechnik GmbH
Ralf Joachim
Raiffeisenstraße 11
D-72127 Kusterdingen
Germany
Tel. +49 7071 3690 52
Mobil: +49 173 9630135
Fax +49 7071 3690 98
Email: [EMAIL PROTECTED]
Web: www.syscon-world.de
-------------------------------------------------
If you wish to unsubscribe from this list, please
send an empty message to the following address:
[EMAIL PROTECTED]
-------------------------------------------------
