David, Can you please create a new issue at http://jira.codehaus.org/browse/CASTOR, and we'll have a go at it.
Werner > -----Original Message----- > From: David Blevins [mailto:[EMAIL PROTECTED] > Sent: Samstag, 11. März 2006 05:48 > To: Castor Dev > Subject: [castor-dev] DatabaseImpl.finalize and false alarm > log message > > Been working with Bruce and Ralf a bit on removing this log > message that actually means nothing for people using > LocalTransactionContext who commit/rollback as they should. > > Bruce, the jar you sent didn't seem to do the trick but this > change to the finalize method does the trick: > > protected void finalize() throws Throwable { > if (_scope == null || !_ctx.isOpen() ) { > return; > } > > if (_ctx instanceof LocalTransactionContext || > (_ctx instanceof GlobalTransactionContext && ! > _isPoolInUseForGlobalTransactions)) { > // retrieve SQL bound to this Database instance > OQLQuery oqlQuery = getOQLQuery(); > String sql = ((OQLQueryImpl) oqlQuery).getSQL(); > > _log.warn(Messages.format("jdo.finalize_close", > this.toString(), _dbName, sql)); > } > close(); > } > > > Aside from the annoying and false log message, I'd like to > avoid the needless synchronized call to close() in the > finalizing thread. > > Anyway, this patch kosher? > > -- > David Blevins > > > > > ------------------------------------------------- > If you wish to unsubscribe from this list, please > send an empty message to the following address: > > [EMAIL PROTECTED] > ------------------------------------------------- > > > ------------------------------------------------- If you wish to unsubscribe from this list, please send an empty message to the following address: [EMAIL PROTECTED] -------------------------------------------------
