Hi Ralf, Ralf Joachim wrote: > Problem with the per-module setup is that you can't commit changes per > module as at least the release notes are not part of the modules. > Because of this you will always need 2 projects. One with the whole > Castor project where you edit release notes and commit all changes and > at least one other for the module you like to do changes at. > > Maybe we can solve this by module specific release notes. Module > specific docs would also make sense in this context. > > Another thing to care about with the per-module setup is, that you may > not recognize that changes at one module brake something at another > module. That's actually not really correct.
> You will recognize such things only when you try to compile the > whole project before commit. Yes and no. Basically, with our current setup (various test suites packaged as modules) you are encouraged to run various Maven goals from the root project. So in your development cycle, there's a switch from working within a module (code, unit test) to work within the project (integration tests, test suites). > So we have the same problem with the > per-module setup compared with using Java 5 settings with the > single-project setup. You recognize problems only when compiling with > maven. Sorry, but I am not sure whether I can follow you here. With Maven, when running e.g. 'mvn test' from the project root, you are capable of catching all gotchas that normally do occur, e.g. breaking contracts between modules, wrongly configured dependencies, etc. In the past twp years, I now and then committed code that was tested locally only. With Maven, such gotchas simply do not happen anymore, as any problem in any phase (pre-compile, compile, package (think sealing), test will break the build. And as such give you enough hints that you have just broken something. But maybe I did misunderstand you ? >It seams to me that both setup options are not ideal. > > Having said that I'm open if you like to commit the per-module settings > to SVN. In the past I thought this isn't required as they get generated > with mvn eclipse:eclipse. Yes, they would, and in a Maven only world I would not commit them. This is just trying to keep in mind that this is not a Maven-only project. > > Ralf > > > Werner Guttmann schrieb: >> Hi Ralf, >> >> Ralf Joachim wrote: >>> I increased Java version to Java 5 only in cpa pom so maven will use the >>> right settings if you work with an eclipse project per Castor module. >> Yes, I have sen that and that should be fine (as we'll be soon doing the >> same on the codegen POM). >>> Only if you work with a single eclipse project for whole Castor the >>> .settings are taken into account. In this case I don't see another >>> chance as to increase dependency for the whole project as any Java 5 >>> syntax, be it in cpa or codegen, will result in compile errors. If you >>> think this should not go into trunk we can take care on this when >>> merging the branch. >> I am afraid that there's no other way to go forward about this, is there >> ? Other than providing .eclipse and .classpath files on a per-module >> base, I don't have any other idea. >>> Ralf >>> >>> >>> Werner Guttmann schrieb: >>>> Hi Ralf, >>>> >>>> just had a look at the patch attached below, and it looks to me like you >>>> are raising compiler version for the complete Eclipse project to Java 5. >>>> I' like to have a brief discussion about the side-effects of this, as >>>> clearly this will render it impossible to spot Java version compliance >>>> issues. >>>> >>>> Regards >>>> Werner >>>> >>>> -------- Original Message -------- >>>> Subject: [castor-scm] [7797] castor/branches/query_engine/cpa: Increase >>>> dependency of cpa to Java 5 >>>> Date: Sun, 3 Aug 2008 09:36:15 -0500 (CDT) >>>> From: [EMAIL PROTECTED] >>>> Reply-To: dev@castor.codehaus.org >>>> To: [EMAIL PROTECTED] >>>> >>>> >>>> >>>> Revision >>>> 7797 <http://fisheye.codehaus.org/changelog/castor/?cs=7797> >>>> Author >>>> rjoachim >>>> Date >>>> 2008-08-03 09:36:15 -0500 (Sun, 03 Aug 2008) >>>> >>>> >>>> Log Message >>>> >>>> Increase dependency of cpa to Java 5 >>>> >>>> >>>> Modified Paths >>>> >>>> * castor/branches/query_engine/.settings/org.eclipse.jdt.core.prefs >>>> <#castorbranchesquery_enginesettingsorgeclipsejdtcoreprefs> >>>> * castor/branches/query_engine/cpa/pom.xml >>>> <#castorbranchesquery_enginecpapomxml> >>>> >>>> >>>> Diff >>>> >>>> >>>> Modified: >>>> castor/branches/query_engine/.settings/org.eclipse.jdt.core.prefs >>>> (7796 => 7797) >>>> >>>> --- castor/branches/query_engine/.settings/org.eclipse.jdt.core.prefs >>>> 2008-08-03 11:33:45 UTC (rev 7796) >>>> +++ castor/branches/query_engine/.settings/org.eclipse.jdt.core.prefs >>>> 2008-08-03 14:36:15 UTC (rev 7797) >>>> @@ -1,4 +1,4 @@ >>>> -#Sat Oct 28 18:16:43 CEST 2006 >>>> +#Sun Jul 20 15:37:40 GMT+01:00 2008 >>>> eclipse.preferences.version=1 >>>> org.eclipse.jdt.core.codeComplete.argumentPrefixes= >>>> org.eclipse.jdt.core.codeComplete.argumentSuffixes= >>>> @@ -9,21 +9,21 @@ >>>> org.eclipse.jdt.core.codeComplete.staticFieldPrefixes=s_ >>>> org.eclipse.jdt.core.codeComplete.staticFieldSuffixes= >>>> org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled >>>> -org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.1 >>>> +org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 >>>> org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve >>>> -org.eclipse.jdt.core.compiler.compliance=1.3 >>>> +org.eclipse.jdt.core.compiler.compliance=1.5 >>>> org.eclipse.jdt.core.compiler.debug.lineNumber=generate >>>> org.eclipse.jdt.core.compiler.debug.localVariable=generate >>>> org.eclipse.jdt.core.compiler.debug.sourceFile=generate >>>> org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning >>>> -org.eclipse.jdt.core.compiler.problem.assertIdentifier=ignore >>>> +org.eclipse.jdt.core.compiler.problem.assertIdentifier=error >>>> org.eclipse.jdt.core.compiler.problem.autoboxing=ignore >>>> org.eclipse.jdt.core.compiler.problem.deprecation=warning >>>> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled >>>> >>>> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=enabled >>>> org.eclipse.jdt.core.compiler.problem.discouragedReference=warning >>>> org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore >>>> -org.eclipse.jdt.core.compiler.problem.enumIdentifier=ignore >>>> +org.eclipse.jdt.core.compiler.problem.enumIdentifier=error >>>> org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore >>>> org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning >>>> >>>> org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning >>>> @@ -62,4 +62,4 @@ >>>> >>>> org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=enabled >>>> org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning >>>> org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning >>>> -org.eclipse.jdt.core.compiler.source=1.3 >>>> +org.eclipse.jdt.core.compiler.source=1.5 >>>> >>>> >>>> Modified: castor/branches/query_engine/cpa/pom.xml (7796 => 7797) >>>> >>>> --- castor/branches/query_engine/cpa/pom.xml 2008-08-03 11:33:45 UTC >>>> (rev 7796) >>>> +++ castor/branches/query_engine/cpa/pom.xml 2008-08-03 14:36:15 UTC >>>> (rev 7797) >>>> @@ -54,8 +54,8 @@ >>>> <groupId>org.apache.maven.plugins</groupId> >>>> <artifactId>maven-compiler-plugin</artifactId> >>>> <configuration> >>>> - <source>1.4</source> >>>> - <target>1.4</target> >>>> + <source>1.5</source> >>>> + <target>1.5</target> >>>> <!-- >>>> <includes> >>>> <include >>>> implementation="java.lang.String">org/exolab/castor/builder/**</include> >>>> >>>> ------------------------------------------------------------------------ >>>> >>>> To unsubscribe from this list please visit: >>>> >>>> http://xircles.codehaus.org/manage_email >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
