Hi Werner, I like the idea of maven profiles that will allow to execute cpactf through maven against different databases. There are only 3 points I do not like much at the current patch which uses maven-sql-plugin to setup database:
1. You have to add connection information for every database in pom.xml and cpactf-conf.xml. And they have to be in sync to execute tests successfully. 2. You have to add <srcFile>...</srcFile> definition in pom.xml for every database engine and every test. As we support 11 database engines and have about 85 tests this will lead us to around 1000 such definitions in pom.xml. In my opinon it will be a nightmare to maintain them. Not to forget the length of the rest of the profil definitions. 3. As mentioned when we introduced maven target to execute against embedded derby, we are still not able to execute/debug cpactf tests against this database engine within eclipse. At http://jira.codehaus.org/browse/CASTOR-2650 I like to address this 3 issues. Therefore I would appreciate if you could wait for some time to let me finish my work on this issue. I am quite confident that this will make support for maven profiles for cpactf much simpler. Will also add this comment to http://jira.codehaus.org/browse/CASTOR-2671. > 1) Can we please use 'qualified' system property names in CPATestCase, > i.e. "org.castor.cpa.ctf.database" rather than just "database", to avoid >any ambiguity ? fine by me > 2) Can we please break apart cpactf-conf.xml into smaller, > database-specific JDO config files, i.e. (re)start having mysql-drv.xml, > derby-embedded.xml, etc. again ? can you please explain the advantage of breaking apart cpactf-conf.xml? As we specify mappings to use within our tests we do not need the configuration part of this file. On the other hand do use the defaults for database and transaction from this file when executing tests in eclipse. In addition I had in mind to enable tests to be used with transaction managers also. Having said that I am aware that some other parts are missing to execute tests with transaction managers. Regards Ralf Werner Guttmann schrieb: > Hi, > > I spent a few hours in the last few days to start adding profiles to the > CPACTF so that the following things are possible by default: > > a) Execution of the test suite for a given database (e.g. Derby, mySQL, > Oracle, ....) by invoking a Maven profile (mvn -P mysql clean test). > b) Addition of a default profile that will be executed if no other > profile is specified. This is required for our continuous integration > definitions, and will default to Derby (embedded). > > I have some changes to the Maven POM ready to review/commit, and I am in > the position to run the CPA test suite both against Derby and mySQL > using Maven profiles. > > Here's a few reasons why I initially started to work on this: > > Benefit a) I wanted complete automation of the database setup through > Maven, and its sql-maven-plugin. In other words, no more manual > interactions required. > Benefit b) I wanted profile-specific declaration of JDBC driver > dependencies, rather than having to use the <optional>true</optional> > property again and again. > Benefit c) I wanted to avoid having to edit cpactf-conf.xml for testing > with different databases. > > I will create a Jira issue later on today, and attach things to review. > > Whilst working on this patch, though, I came across a few things I'd > like to change: > > 1) Can we please use 'qualified' system property names in CPATestCase, > i.e. "org.castor.cpa.ctf.database" rather than just "database", to avoid > any ambiguity ? > 2) Can we please break apart cpactf-conf.xml into smaller, > database-specific JDO config files, i.e. (re)start having mysql-drv.xml, > derby-embedded.xml, etc. again ? > > Any objections ? If not, let me include those changes with an update to > the original patch later on. > > Cheers > Werner > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > -- Syscon Ingenieurbüro für Meß- und Datentechnik GmbH Ralf Joachim Raiffeisenstraße 11 72127 Kusterdingen Germany Tel. +49 7071 3690 52 Mobil: +49 173 9630135 Fax +49 7071 3690 98 Internet: www.syscon.eu E-Mail: ralf.joac...@syscon.eu Sitz der Gesellschaft: D-72127 Kusterdingen Registereintrag: Amtsgericht Stuttgart, HRB 382295 Geschäftsleitung: Jens Joachim, Ralf Joachim --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
