[
https://issues.apache.org/jira/browse/CAUSEWAY-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748810#comment-17748810
]
Daniel Keir Haywood commented on CAUSEWAY-3544:
-----------------------------------------------
Hi [~ahuber] - I'm happy to pick this one up, do you agree with the analysis?
> Refactor preInteractionClosed calling of completeAndPublishCommand, instead
> treat similar to audit trail publisher.
> -------------------------------------------------------------------------------------------------------------------
>
> Key: CAUSEWAY-3544
> URL: https://issues.apache.org/jira/browse/CAUSEWAY-3544
> Project: Causeway
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-RC2
> Reporter: Daniel Keir Haywood
> Assignee: Daniel Keir Haywood
> Priority: Minor
> Fix For: 2.0.0-RC3
>
>
> In InteractionServiceDefault#preInteractionClosed() we currently call the
> `completeAndPublishCurrentCommand` first, and then later we loop around all
> transactionBoundaryAwareBeans callback, tell them to do their stuff. One of
> those is auditing (EntityChangePublishing).
> I don't see any reason that command publishing is any different from
> auditing, so I think we should refactor to use the same callbacks..
> Note that ExecutionPubilshing is not a transactionally aware aspect ... we
> publish that more eagerly, as each action invocation (or property edit) is
> executed .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)