Daniel Keir Haywood created CAUSEWAY-3610:
---------------------------------------------

             Summary: AuditTrailEntry instances not correlated back to command 
if executed via CommandExecutorService (ie background commands)
                 Key: CAUSEWAY-3610
                 URL: https://issues.apache.org/jira/browse/CAUSEWAY-3610
             Project: Causeway
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.0-RC2
            Reporter: Daniel Keir Haywood
            Assignee: Daniel Keir Haywood
             Fix For: 2.0.0-RC3


The AuditTrailEntry#getInteractionId() is copied from 
InteractionService#currentInteractionId(), which is a different value than that 
of InteractionService#currentInteraction().getInteractionId() when the 
CommandExecutorService is in use.

This is because the latter delegates to Interaction#getCommand(), where the 
CommandExecutorService mutates the interactionId with that of the command being 
executed, whereas the former is unchanged with its own copy of the 
interactionId taken prior to this.

The fix I think is to eliminate the cache in the former so that 
InteractionService#currentInteractionId() returns the correct value (that of 
the interactionId of the command being executed).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to