andi-huber commented on code in PR #3426:
URL: https://github.com/apache/causeway/pull/3426#discussion_r2874128651


##########
core/metamodel/src/main/java/org/apache/causeway/core/metamodel/util/Facets.java:
##########
@@ -460,4 +458,16 @@ private Predicate<? super ValueFacet> typeGuard(
                     
ClassUtils.resolvePrimitiveIfNecessary(valueFacet.getValueClass()));
     }
 
+
+    //FIXME this is just an experimental shortcut

Review Comment:
   Technical concern: ThreadLocal values are not cleared at the end of a 
request cycle, hence can be picked up by a follow up and provide invalid state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to