Hmm.   Not sure.  I seem to recall that there's some kind of visitor
pattern being used for node processing in the translator, but I don't
know if that's a close enough match.

Well, if nothing else, there's some generated-SQL unit tests we can reuse :-)

The new pattern seems a lot more amenable to supporting outer joins.
Perhaps it makes more sense to just rewrite it from scratch.

On 4/1/07, Andrus Adamchik <[EMAIL PROTECTED]> wrote:
The translator is based on EJB QL visitor interface [1] and generates
a SQLTemplate. I am not sure this can be reused either?

Andrus

[1] http://svn.apache.org/repos/asf/cayenne/main/trunk/framework/
cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/ejbql/
EJBQLExpressionVisitor.java


On Apr 1, 2007, at 9:21 PM, Mike Kienenberger wrote:
> Oh.  Maybe I'm confused.  Are we talking about the expression
> language?  Or the translator code?   If just the EL, then there's
> nothing worth saving there.
>
> On 4/1/07, Andrus Adamchik <[EMAIL PROTECTED]> wrote:
>> Hi Mike,
>>
>> Could you post a summary of how this works?
>>
>> I suspect there won't be much code reuse with EJB QL implementation
>> (although functionally EJB QL should be able to replace any of the
>> expression stuff).
>>
>> Andrus
>>
>>
>> On Apr 1, 2007, at 8:50 PM, Mike Kienenberger wrote:
>>
>> > Andrus,
>> >
>> > Are you interested in the joins support (and outer join support)
>> that
>> > I added to 1.2?   I can try to get it integrated into either 2.0 or
>> > 3.0 later this week if you want.   The biggest weakness was the
>> > expression language support backing it.


Reply via email to