Re: svn commit: r584611 - in /cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne: ObjectId.java access/jdbc/SQLTemplateAction.java util/IndexPropertyList.java

[Andrus Adamchik]

Hi Kevin,

Nice work cleaning up the code tonight!
One question - why do you think the break statement below is not  
needed? (Keep in mind that it is past 1am in my TZ right now, so I  
may be asking stupid/obvious stuff :-))

Andrus


On Oct 15, 2007, at 12:30 AM, [EMAIL PROTECTED] wrote:

Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/ 
src/main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/ 
cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/access/ 
jdbc/SQLTemplateAction.java?rev=584611&r1=584610&r2=584611&view=diff
====================================================================== 
========
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/ 
main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java  
(original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/ 
main/java/org/apache/cayenne/access/jdbc/SQLTemplateAction.java Sun  
Oct 14 14:30:39 2007
@@ -159,10 +157,7 @@
                                     t1);
                         }
                         finally {
-                            if (iteratedResult) {
-                                break;
-                            }
-                            else {
+                            if (!iteratedResult) {
                                 resultSet.close();
                             }
                         }