Current EmbeddedAttribute extends Attribute, but I wonder whether it
should be extending ObjAttribute. If it were to do so, lots of nice
simplification will be had by having getAttributes return
Collection<ObjAttribute> rather than Collection<Attribute> (and the
equivalent for getRelationships and also the same for DbEntity).
If not, then there appear to be places in Cayenne which assume the
collection just contains ObjAttributes:
EntityMergeSupport.getMeaningfulFKs() (line 170)
PrefetchProcessorJointNode (line 205)
and more...
It does seem to me that EmbeddedAttribute should logically extend
ObjAttribute since it is a specialised case of one. What do you think?
Ari Maniatis
-------------------------->
ish
http://www.ish.com.au
Level 1, 30 Wilson Street Newtown 2042 Australia
phone +61 2 9550 5001 fax +61 2 9550 4001
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
