[
https://issues.apache.org/cayenne/browse/CAY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893#action_12893
]
Kevin Menard commented on CAY-1062:
-----------------------------------
Correct. But the Velocity templates in the Windows artifacts can use Windows
EOL, the Mac artifacts Mac EOL, and the tarballs Linux EOL. This would obviate
the need for maintaining multiple versions of the Velocity templates that only
differ by EOL. Since the only way to build the Windows assembly is on Windows
and the Mac assembly on Mac, setting EOL in our SVN would largely accomplish
that. Granted, this isn't as foolproof as a runtime OS check -- e.g., there's
nothing stopping me from using the tarball on Windows and getting the wrong
EOL. I suspect this isn't a case that arises frequently, except when a user
grabs an artifact from the maven repo. At that point, we lose control.
So, two separate issues. A user can address any EOL problem he has with his
SCM. We should do our best to provide the appropriate EOL for each platform
though, and using EOL in our SVN might help get us there.
> Code Generation line ending consistency: ImportUtils
> ----------------------------------------------------
>
> Key: CAY-1062
> URL: https://issues.apache.org/cayenne/browse/CAY-1062
> Project: Cayenne
> Issue Type: Bug
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Priority: Trivial
> Fix For: 3.0
>
>
> ImportUtils should use UNIX line ending when generating imports in
> 'generate'... Otherwise classes generated on UNIX and Windows will differ in
> line endings, and in a developer group that is a mix of windows/unix/mac,
> people will constantly override each other. Note that the rest of the
> template ensures line ending consistency, it is only the ImportUtils that use
> platform-specific endings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
