Indeed. I misread the patch/comment. He simply added a test to ensure that it was being called with CACHED option. Sorry for the confusion. -- Kevin
On Sat, Aug 23, 2008 at 11:22 AM, Andrus Adamchik <[EMAIL PROTECTED]>wrote: > We ARE creating HSQLDB tables with CACHED option already. See "createTable" > method: > > > http://fisheye6.atlassian.com/browse/cayenne/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/dba/hsqldb/HSQLDBAdapter.java?r=617856 > > Andrus > > > On Aug 23, 2008, at 6:13 PM, Kevin Menard wrote: > > Hi, >> In his patch for CAY-1095 [1], Robert indicated that we should be created >> HSQLDB tables as cached. Not being overly familiar with it, I looked into >> the matter a bit, and I don't think it would pose any serious backwards >> compatibility issues for us. And it does indeed seem to bring a lot of >> benefits, save in the case where a database is small enough to fit >> entirely >> into memory. Before I go make the change, however, I wanted to know why >> we >> weren't doing it in the first place and if there's any reason that we >> shouldn't. >> >> >> [1] -- https://issues.apache.org/cayenne/browse/CAY-1095 >> >> -- >> Thanks, >> Kevin >> > >
