[
https://issues.apache.org/cayenne/browse/CAY-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143#action_13143
]
Andrus Adamchik commented on CAY-1116:
--------------------------------------
I am deferring to Tore to judge the patch details, as it is related to the
merge function that he knows better than anyone. So let me just make a few
general observations.
1. Is that really a "add generated PK support to SQLite" patch? It changes
DbAdapter API, so I'd like to have reasons for this change stated a bit more
explicitly in Jira, as DbAdapter is one of the important integration points in
Cayenne, and I'd rather we keep it clean and change only if absolutley needed.
2. I am a bit concerned about DbAdapter methods getting too specialized.
"createTableAppendColumnWithoutNullClause"... it is totally unclear what this
method should do to a person writing her own adapter...
3. A formal nitpick: Cayenne is all Java 5 now. So having a StringBuffer in the
method sigs is not a good idea. Appendable or StringBuilder is probably a
better choice.
> [patch] add generated PK support to SQLite
> ------------------------------------------
>
> Key: CAY-1116
> URL: https://issues.apache.org/cayenne/browse/CAY-1116
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Andrus Adamchik
> Attachments: AutoIncrement-SQLite.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
