Hi Evgeny,
First of all, thanks for your work on this patch. This closes arguably
the biggest usability hole in SQLTemplate.
I Just committed the patch, with the only change being removal of the
public case transform method from ColumnDescriptor and inlining it
into the builder class. Also added this comment to the builder code:
// TODO: andrus, 10/14/2009 - 'equalsIgnoreCase' check can result in
// subtle bugs in DBs with case-sensitive column names (or when quotes
are
// used to force case sensitivity). Alternatively using 'equals' may
miss
// columns in case-insensitive situations.
In a couple of days we'd see if this problem pops up during the tests
with DBs other than HSQLDB. Hopefully not.
2. Also with this and CAY-1293 patch by Olga, we are very close to
freezing the code for the 3.0 Beta. Are you planning to work on a
patch for CAY-1280 in the nearest future, or are you ok to postpone it
till 3.1 release (In practical terms, 3.1 choice means that if you'd
like to use this in your work, you'd have to start using trunk builds
with your apps, or maintain the internal patched version of 3.0).
Cheers,
Andrus
