Hi Olga,

Nice work switching the preferences away from HSQLDB. There are still some OS X weirdness (since you are not on Mac, I guess I can take a look at it myself, especially since I wanted to reorg the other OS- specific code anyways).

Here is one more save error, similar to what Andrey reported earlier. I created a new project with 2 empty DataMaps and one empty DataNode. I get this on save:

java.lang.NullPointerException
at org .apache .cayenne .project2 .validation.DataNodeValidator.validateName(DataNodeValidator.java:69) at org .apache .cayenne .project2.validation.DataNodeValidator.validate(DataNodeValidator.java: 30) at org .apache .cayenne .project2 .validation .ValidationVisitor .visitDataNodeDescriptor(DefaultProjectValidator.java:228) at org .apache .cayenne .project2 .validation .ValidationVisitor .visitDataChannelDescriptor(DefaultProjectValidator.java:181) at org .apache .cayenne .project2 .validation .ValidationVisitor .visitDataChannelDescriptor(DefaultProjectValidator.java:161) at org .apache .cayenne .configuration .DataChannelDescriptor.acceptVisitor(DataChannelDescriptor.java:111) at org .apache .cayenne .project2 .validation .DefaultProjectValidator.validate(DefaultProjectValidator.java:89) at org .apache .cayenne.modeler.action.SaveAsAction.performAction(SaveAsAction.java: 154) at org .apache .cayenne.modeler.action.SaveAsAction.performAction(SaveAsAction.java: 147)

Cheers,
Andrus

On Mar 4, 2010, at 10:51 AM, Ольга Ткачева wrote:

fixed

2010/3/4 Andrey Razumovsky <[email protected]>

I'm still seeing problems that block my usage of 3.1 modeler : ( [probably
not related to this commit, but appeared recently]
Now, I can't save project (our test project):
java.lang.NullPointerException
  at

org .apache .cayenne .project2 .validation .ProcedureParameterValidator .validate(ProcedureParameterValidator.java:32)
  at

org .apache .cayenne .project2 .validation .ValidationVisitor .visitProcedureParameter(DefaultProjectValidator.java:324)

After I commented out validation, I got another NPE (something in
Entity$PathIterator). Could someone who knows about new changes have a look
please?

2010/3/4 Ольга Ткачева <[email protected]>

Thanks, I will look it tomorrow morning.

2010/3/3 Andrey Razumovsky <[email protected]>

Hi Olga,

I'm afraid "open project" menu item doesn't work anymore:
java.lang.NullPointerException
  at



org .apache .cayenne .modeler.Application.getMainPreferenceForProject(Application.java: 263)
  at



org .apache .cayenne .modeler .util.CayenneController.getViewPreferences(CayenneController.java: 109)
  at



org .apache .cayenne .modeler .util.CayenneController.getLastDirectory(CayenneController.java:92)
  at



org .apache .cayenne .modeler.action.ProjectOpener.getDefaultStartDir(ProjectOpener.java: 158)
  at



org .apache .cayenne .modeler.action.ProjectOpener.openProjectFile(ProjectOpener.java:132)
  at



org .apache .cayenne .modeler .action.OpenProjectAction.performAction(OpenProjectAction.java:96)

2010/3/3 <[email protected]>

Author: oltka
Date: Wed Mar  3 13:26:27 2010
New Revision: 918465

URL: http://svn.apache.org/viewvc?rev=918465&view=rev
Log:
CAY-1327 Migrate HSQLDB modeler preferences to Java preferences API

Modified:




cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/ apache/cayenne/modeler/CayenneModelerController.java

Modified:



cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/ apache/cayenne/modeler/CayenneModelerController.java
URL:



http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/CayenneModelerController.java?rev=918465&r1=918464&r2=918465&view=diff




= = = = = = = = = =====================================================================
---



cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/ apache/cayenne/modeler/CayenneModelerController.java
(original)
+++



cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/ apache/cayenne/modeler/CayenneModelerController.java
Wed Mar  3 13:26:27 2010
@@ -82,7 +82,7 @@
       FSPath path = (FSPath) application
               .getCayenneProjectPreferences()
               .getProjectDetailObject(
-                        DataMapDefaults.class,
+                        FSPath.class,
                       getViewPreferences().node("lastEOMDir"));

       if (path.getPath() == null) {





--
Andrey




--
Olga Tkacheva




--
Andrey




--
Olga Tkacheva

Reply via email to