I would push it to 3.2. Exactly because I don't feel the issue is completely solved here.
Andrus On Jun 3, 2012, at 5:29 PM, Michael Gentry wrote: > Should we include this in 3.1? > > https://issues.apache.org/jira/browse/CAY-1622 > > Also, unless I'm mistaken, the attached patch will still leave > compilation warnings in the subclass, since only the superclass will > get a newly generated serial number. I think I'd be more inclined to > put @SuppressWarnings("serial") on both the subclass and superclass. > > Thoughts? > > Thanks, > > mrg > > > On Tue, May 29, 2012 at 5:47 AM, Andrus Adamchik <[email protected]> > wrote: >> Hmm.. we didn't in the previous build on the same day: >> >> https://builds.apache.org/job/Cayenne-trunk/716/ >> >> and the change was kind of irrelevant to the build: >> >> https://fisheye6.atlassian.com/changelog/cayenne/?cs=1343404 >> >> Andrus >> >> >> On May 28, 2012, at 10:19 PM, Aristedes Maniatis wrote: >> >>> On 29/05/12 8:02am, Andrus Adamchik wrote: >>>> I just cloned trunk to STABLE-3.1 branch. Trunk is now the future 3.2 >>>> release. >>>> >>>> A 3.1 beta was assembled and can be found at [1] in its Maven form and at >>>> [2] as source and binary assemblies. Please evaluate the release and cast >>>> your votes. >>>> >>>> Thanks, >>>> Andrus >>>> >>>> [1] >>>> https://repository.apache.org/content/repositories/orgapachecayenne-146/ >>>> [2] http://people.apache.org/~aadamchik/release/3.1B1/ >>> >>> >>> I've disabled the ci tests just now (since clearly we aren't quite ready >>> for that), but we do have test failures also in Java 7: >>> >>> https://builds.apache.org/job/Cayenne-trunk/ >>> >>> >>> java.sql.SQLException: Attempt to insert null into a non-nullable column in >>> statement [ALTER TABLE PAINTING ALTER COLUMN NEWCOL2 SET NOT NULL] >>> at org.hsqldb.jdbc.Util.sqlException(Unknown Source) >>> at org.hsqldb.jdbc.jdbcStatement.fetchResult(Unknown Source) >>> at org.hsqldb.jdbc.jdbcStatement.execute(Unknown Source) >>> at >>> org.apache.cayenne.merge.AbstractToDbToken.executeSql(AbstractToDbToken.java:57) >>> at >>> org.apache.cayenne.merge.AbstractToDbToken.execute(AbstractToDbToken.java:45) >>> at org.apache.cayenne.merge.MergeCase.execute(MergeCase.java:131) >>> at >>> org.apache.cayenne.merge.MergeCase.assertTokensAndExecute(MergeCase.java:188) >>> at >>> org.apache.cayenne.merge.SetAllowNullToDbTest.test(SetAllowNullToDbTest.java:43) >>> >>> >>> Is this a real test failure? >>> >>> >>> >>> Ari >>> >>> >>> >>> -- >>> --------------------------> >>> Aristedes Maniatis >>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A >>> >>> >>> >> >
