Hi Andrus, > 2. - Signatures : no public key present in the KEYS file I've added my key to the master branch. Sorry, I thought that adding to the release branch would be enough.
> 6. - no cayenne-java8.jar present in assembly. Looks like I should provide some extra configurations to include cayenne-java8.jar to the assembly. I'll check it. 2016-02-06 13:53 GMT+03:00 Andrus Adamchik <and...@objectstyle.org>: > I just went through verification checklist, and here is what I have: > > 1. + MD5 : match > 2. - Signatures : no public key present in the KEYS file > 3. + rat : passes > 4. + builds from source > 5. + Modeler runs on OS X and Windows > 6. - no cayenne-java8.jar present in assembly. > > We need to resolve #2 and #6. The last one requires creating a new > assembly. So I am -1 on the current set of files. > > I also found a few non-blocking issues - Modeler copyright year was 2014 > (I fixed it on master and M3 branches). Also "About" menu reads "About > OSXMain" instead of "About CayenneModeler". This may be more involved then > it looks like, and we can fix it in the later releases. I'll jira in a > moment. > > Andrus > > > > On Feb 6, 2016, at 12:03 PM, Andrus Adamchik <and...@objectstyle.org> > wrote: > > Savva, > > I don't see your key in this file: > https://github.com/apache/cayenne/blob/master/docs/doc/src/main/resources/KEYS > > Could you please add it and commit. Once this is done, I will copy it to > http://www.apache.org/dist/cayenne/KEYS (an official published location). > > Thanks, > Andrus > > On Feb 5, 2016, at 11:37 PM, Savva Kolbachev <s.kolbac...@gmail.com> > wrote: > > Ah, yes. Thanks for reminder. > > Here's a link to comparison table: > > https://docs.google.com/document/d/1sLR2CykqZSoPU2WdQaKKcp4rLgwja4fmPEOvYw5zZgc/edit?usp=sharing > > In short, there are a few new failed tests for MS SQL Server. Some of them > are specific to settings of my database. For one I've already created a > JIRA ticket [1]. Anyway they are not critical. > > We have a more complicated situation with Oracle. As you could see there > are many tests in error, but most of them are related to our SchemaBuilder. > Dropping tables is very slow and takes a ton of time in our case. There are > some other frustrating things like "sequence does not exist" error while > SchemaBuilder is trying to delete sequences and etc. Some of them I had to > accommodate manually. So maybe we should develop a new approach for > rebuilding schemas for Oracle. > > Any comments and suggestions are welcome! > > [1] https://issues.apache.org/jira/browse/CAY-2056 > > 2016-02-05 14:19 GMT+03:00 Andrus Adamchik <and...@objectstyle.org>: > > Hi Savva, > > Thanks for preparing the release! I know you've done some cross-DB testing > of it prior to making the assembly. Could you please share a report on the > DBs and test results? > > Thanks, > Andrus > > > On Feb 5, 2016, at 2:14 PM, Savva Kolbachev <s.kolbac...@gmail.com> > > wrote: > > > Hi all, > I'm glad to tell you that I've prepared 4.0.M3 artifacts for voting. > > Maven artifacts: > https://repository.apache.org/content/repositories/orgapachecayenne-1007 > Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.0.M3/ > > Please evaluate and cast your votes. > > -- > Thanks and Regards > Savva Kolbachev > > > > > > -- > Thanks and Regards > Savva Kolbachev > > > > -- Thanks and Regards Savva Kolbachev
