Ah, you are right. I was running rat on both the src download and my git checkout (because I was trying to verify that source matched git where it mattered) and erroneously confused the two.
So we are all good. I can see a few other commits that might need to be merged back to master: https://github.com/apache/cayenne/compare/master...4.0.M3_prerelease Ari On 12/02/2016 4:16pm, Andrus Adamchik wrote: > I think those are problems specific on master, as fixes done to the release > branch weren't merged to master right away. These files are ok on the release > branch, so running rat against cayenne-4.0.M3-src.tar.gz doesn't give any > errors. Which is good news - it means the release is fully compliant. > > Andrus > > >> On Feb 12, 2016, at 3:03 AM, Aristedes Maniatis <a...@maniatis.org> wrote: >> >> Only a couple of files: >> >> https://github.com/apache/cayenne/commit/ff38058ea5a86b2ca99de7c1c104ec81779fe6ac >> >> On 12/02/2016 10:39am, Mike Kienenberger wrote: >>> What files did you find? I ran rat manually and didn't see anything. >>> >>> On Thu, Feb 11, 2016 at 6:23 PM, Aristedes Maniatis <a...@maniatis.org> >>> wrote: >>>> On 12/02/2016 7:56am, Mike Kienenberger wrote: >>>>> ## mvn apache-rat currently unused for cayenne >>>>> # manually verify that there are no unknown or unapproved licensed files >>>>> ./rat.sh ../../../../java/apache-rat-0.11/apache-rat-0.11.jar >>>>> ##mvn apache-rat:check >>>>> # To check for all errors, if more than one project is affected >>>>> # mvn apache-rat:check -Drat.numUnapprovedLicenses=9999 >>>>> # To see details of rat failure >>>>> # mvn -e -X apache-rat:check >>>> >>>> >>>> The maven target works OK for me and discovered a couple of files missing >>>> licenses. I'll tidy them up now, but I don't think they should cause us to >>>> halt this release. >>>> >>>> My other reviews look good. +1 >>>> >>>> Ari >>>> >>>> >>>> >>>> -- >>>> --------------------------> >>>> Aristedes Maniatis >>>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A >> >> -- >> --------------------------> >> Aristedes Maniatis >> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > -- --------------------------> Aristedes Maniatis GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A