While I don't have any EOModels to test this, the code looks great to me. In fact I just applied to PR.
Andrus > On Aug 5, 2016, at 5:19 PM, Musall Maik <[email protected]> wrote: > > All right, > > I think I improved a few minor things, and create a first pull request. I'd > like feedback on whether or not this is going in the right direction. > > https://github.com/apache/cayenne/pull/103 > > Thanks > Maik > >> Am 04.08.2016 um 18:07 schrieb Mike Kienenberger <[email protected]>: >> >> Yes, please continue to improve it. I first used it back in 2003, and >> it's still being used 13 years later. >> >> On Thu, Aug 4, 2016 at 4:38 AM, Musall Maik <[email protected]> wrote: >>> >>>> Am 04.08.2016 um 01:26 schrieb Aristedes Maniatis <[email protected]>: >>>> >>>> On 4/08/2016 5:27am, Musall Maik wrote: >>>>> There's still a bunch of details to fix, like TEXT columns (postgresql >>>>> clobs) ending up as varchar with no length, the parser not being able to >>>>> cope with unicode umlauts in documentation (similar to CAY-1291 which is >>>>> also still unsolved), and more. >>>> >>>> Perhaps I'm telling you the obvious, but don't overlook the ability to >>>> write xslt or just regex against the XML model file in order to tidy up >>>> some things. >>>> >>> >>> Of course. But you know, we just had the "From EOF to Cayenne" topic at the >>> WOWODC conference in June, and I guess (hope) a few more people might try >>> to move to Cayenne in the near future. So, the benefit of any work put into >>> the model importer instead of run-once-on-my-project tools is multiplied by >>> the number of users that are using the importer. >>> >>> Maik >>> >
