Thanks Nikita :) 4.2 is looking awesome.
> On 18 May 2020, at 10:11, Nikita Timofeev <ntimof...@objectstyle.com> wrote: > > Hi all, > > Joint prefetching still gives incorrect result in 4.2. This message > just lost in the process. > I've returned it to the new SelectTranslator. Moreover it's report > toMany relationships only. > > On Sat, May 16, 2020 at 1:40 PM Hugi Thordarson <h...@karlmenn.is> wrote: >> >> Hi Andrus! >> >> The message is "Query uses both limit and joint prefetch, this most probably >> will lead to incorrect result. Either use disjointById prefetch or get full >> result set.", logged in the aptly named >> DefaultselectTranslator.checkLimitAndJointPrefetch(). >> >> But. I see now that it's only in 4.1. Seems it was removed with the new >> SelectTranslator implementation in 4.2 (with Nikita's commit >> f6b2dac9667343928324cd7ce364ee6e5df17275). >> >> I can't see anything analogous in 4.2… Would be interesting to know if joint >> prefetching with a fetch limit just works now, or if the potential problem >> is no longer logged. >> >> - hugi >> >> >>> On 16 May 2020, at 10:12, Andrus Adamchik <and...@objectstyle.org> wrote: >>> >>> Hi Hugi, >>> >>> I think you are right in general. But I can't seem to find the warning you >>> are referring to. What is the exact text, so I can search for it in the >>> code? >>> >>> Andrus >>> >>>> On May 16, 2020, at 11:23 AM, Hugi Thordarson <h...@karlmenn.is> wrote: >>>> >>>> Hi all, >>>> just wondering; the warning that's logged if a query uses a joint prefetch >>>> in conjunction with a limit—shouldn't that only apply to to-many >>>> relationships? >>>> >>>> Cheers, >>>> - hugi > > > > -- > Best regards, > Nikita Timofeev
