Yep, seems like this release is done for now. I'm -1 too. The way we are retaining objects in the context relies on the caller to have some reference to it. With the latest fix a caller doesn't have a reference to the internal object stored in the ObjectStore and GC is free to clean it up at any time, even right after returning it. Definitely not a thing we want to push live.
On Thu, Mar 6, 2025 at 5:55 PM Hugi Thordarson <h...@karlmenn.is> wrote: > On a probably related note, I had some weirdness in a project using > 5.0-SNAPSHOT after the CAY-2876 merge (objects seemingly randomly > disappearing). > > Didn't manage to replicate it reliably so I put it on the back burner for > looking at this week (sorry about not reporting it immediately, didn't know > it was scheduled for an impending 4.2 release and wanted to at least > reproduce it). > > - hugi > > > > > On 6 Mar 2025, at 13:49, Andrus Adamchik <aadamc...@gmail.com> wrote: > > > > Yeah, we need to investigate. I am -1 for now > > > >> On Mar 6, 2025, at 8:46 AM, Michael Gentry <blackn...@gmail.com> wrote: > >> > >> I was going to do release verification today. Are we going to pause the > >> release for now? > >> > >> Thanks, > >> mrg > >> > >> On Thu, Mar 6, 2025 at 7:47 AM Andrus Adamchik <aadamc...@gmail.com> > wrote: > >> > >>> Hmm.. This should not happen under any retain strategy. > >>> > >>>> On Mar 6, 2025, at 3:58 AM, Jurgen Doll <jur...@ivoryemr.co.za> > wrote: > >>>> > >>>> Hi Nikita > >>>> > >>>> In my application, as a result of the memory leak fix, I'm > experiencing > >>> frequent and consistent "CayenneRuntimeException: [v.4.2.2 Mar 04 2025 > >>> 14:34:19] No object is registered in context with Id ...." thrown from > >>> ObjectStore.registerDiff(ObjectStore.java:178) > >>>> If I change SERVER_OBJECT_RETAIN_STRATEGY_PROPERTY to "soft", as you > did > >>> in the test, then the exceptions go away. > >>>> I recommend adding a suitable comment to the release notes warning > that > >>> this might happen and detailing how to remedy it. > >>>> Best regards, > >>>> Jurgen > >>>> > >>>> On Mar 5 2025, at 5:44 pm, John Huss <johnth...@gmail.com> wrote: > >>>>> +1, this passed all my checks. > >>>>> > >>>>> On Tue, Mar 4, 2025 at 9:41 AM Nikita Timofeev < > >>> ntimof...@objectstyle.com> > >>>>> wrote: > >>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> Here is the next maintenance release of Cayenne 4.2. > >>>>>> There are not many issues fixed, but still important ones. > >>>>>> > >>>>>> Release notes: > >>>>>> https://github.com/apache/cayenne/blob/4.2.2/RELEASE-NOTES.txt > >>>>>> Maven repo: > >>>>>> > >>> > https://repository.apache.org/content/repositories/orgapachecayenne-1059 > >>>>>> Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.2.2/ > >>>>>> > >>>>>> Please evaluate and cast your votes. > >>>>>> > >>>>>> -- > >>>>>> Best regards, > >>>>>> Nikita Timofeev > >>>>>> > >>>>> > >>>> > >>> > >>> > > > > -- Best regards, Nikita Timofeev
