RexXiong commented on code in PR #973: URL: https://github.com/apache/incubator-celeborn/pull/973#discussion_r1023484255
########## client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala: ########## @@ -53,7 +54,8 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin private val pushReplicateEnabled = conf.pushReplicateEnabled private val partitionSplitThreshold = conf.partitionSplitThreshold private val partitionSplitMode = conf.partitionSplitMode - private val partitionType = conf.shufflePartitionType + // shuffle id -> partition type + private val shufflePartitionType = new ConcurrentHashMap[Int, PartitionType]() Review Comment: I don't think we should limit this. May be add this in future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
