waitinfuture commented on code in PR #985:
URL:
https://github.com/apache/incubator-celeborn/pull/985#discussion_r1028973512
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -100,10 +100,11 @@ public ResourceResponse
handleWriteRequest(ResourceProtos.ResourceRequest reques
int pushPort;
int fetchPort;
int replicatePort;
- Map<String, DiskInfo> disks;
+ Map<String, DiskInfo> diskUsage;
Map<UserIdentifier, ResourceConsumption> userResourceConsumption;
List<Map<String, Integer>> slots = new ArrayList<>();
Map<String, Map<String, Integer>> workerAllocations = new HashMap<>();
+ Map<String, Long> shuffleDiskUsage = new HashMap<>();
Review Comment:
appDiskUsage
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -138,7 +138,7 @@ message PbHeartbeatFromWorker {
int32 fetchPort = 4;
int32 replicatePort = 5;
repeated PbDiskInfo disks = 6;
- repeated string shuffleKeys = 7;
+ map<string, int64> shuffleDiskUsage = 7;
Review Comment:
This change will break the behavior of identifying expired shuffles in
handleHeartbeatFromWorker.
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -100,10 +100,11 @@ public ResourceResponse
handleWriteRequest(ResourceProtos.ResourceRequest reques
int pushPort;
int fetchPort;
int replicatePort;
- Map<String, DiskInfo> disks;
+ Map<String, DiskInfo> diskUsage;
Review Comment:
diskInfos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
