zwangsheng opened a new pull request, #1020:
URL: https://github.com/apache/incubator-celeborn/pull/1020

   # [IMPROVEMENT] Improve celeborn script logic
   
   ### What changes were proposed in this pull request?
   Improve celeborn scripts `celeborn-daemon.sh` and `celeborn-class.sh` print 
log and logic.
   
   ### Why are the changes needed?
   
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   ### What are the items that need reviewer attention?
   1. We may left celeborn-test which used to test if we can touch file in log 
dir.
   2. `CELEBORN_PRINT_LAUNCH_COMMAND` was not used in `celeborn-daemon.sh`, 
move it to `celeborn-class.sh` and set default to 0 for help developer debug 
java command. 
   
   ### Related issues.
   
   
   ### Related pull requests.
   
   
   ### How was this patch tested?
   
   
   /cc @related-reviewer
   
   /assign @main-reviewer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to