zy-jordan commented on code in PR #993:
URL:
https://github.com/apache/incubator-celeborn/pull/993#discussion_r1034447640
##########
client/src/main/java/org/apache/celeborn/client/write/PushState.java:
##########
@@ -88,4 +96,20 @@ public boolean addBatchData(String addressPair,
PartitionLocation loc, int batch
public DataBatches takeDataBatches(String addressPair) {
return batchesMap.remove(addressPair);
}
+
+ public void addFlightBatches(int batchId, PartitionLocation loc) {
Review Comment:
hello, @waitinfuture . Execute me, could tell me why put a string object is
better than an object reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
