AngersZhuuuu commented on code in PR #1031:
URL:
https://github.com/apache/incubator-celeborn/pull/1031#discussion_r1036638021
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -376,10 +376,16 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
def rpcConnectThreads: Int = get(RPC_CONNECT_THREADS)
def rpcLookupTimeout: RpcTimeout =
new RpcTimeout(get(RPC_LOOKUP_TIMEOUT).milli, RPC_LOOKUP_TIMEOUT.key)
- def rpcAskTimeout: RpcTimeout =
- new RpcTimeout(get(RPC_ASK_TIMEOUT).milli, RPC_ASK_TIMEOUT.key)
- def clientRpcAskTimeout: RpcTimeout =
- new RpcTimeout(get(CLIENT_RPC_ASK_TIMEOUT).milli,
CLIENT_RPC_ASK_TIMEOUT.key)
+ def rpcAskTimeout(func: String = "default"): RpcTimeout = {
+ if (func == "client") {
+ HARpcAskTimeout
+ } else {
+ val key = RPC_ASK_TIMEOUT.key.replace("<func>", func)
+ new RpcTimeout(getTimeAsMs(key,
NETWORK_TIMEOUT.defaultValueString).milli, key)
+ }
+ }
+ def HARpcAskTimeout: RpcTimeout =
Review Comment:
haRpcTimeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
