RexXiong commented on code in PR #1003:
URL:
https://github.com/apache/incubator-celeborn/pull/1003#discussion_r1037156128
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClient.java:
##########
@@ -147,11 +147,21 @@ public abstract int mergeData(
public abstract void pushMergedData(String applicationId, int shuffleId, int
mapId, int attemptId)
throws IOException;
- // Report partition locations written by the completed map task
+ // Report partition locations written by the completed map task of
ReducePartition Shuffle Type
public abstract void mapperEnd(
String applicationId, int shuffleId, int mapId, int attemptId, int
numMappers)
throws IOException;
+ // Report partition locations written by the completed map task of
MapPartition Shuffle Type
+ public abstract void mapPartitionMapperEnd(
+ String applicationId,
+ int shuffleId,
+ int mapId,
Review Comment:
> Do we need mapId? PartitionId already contains mapId
Not so necessary, But to avoid lifecycle manager to understand the semantics
of partitionId. I think add mapId would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
