Kindly reminder, this release is packaged via SBT, better to use `./build/make-distribution.sh --sbt-enabled —release` for building check.
> On Dec 22, 2023, at 12:48, Ethan Feng <[email protected]> wrote: > > -1(binding) > > There is a bug that needs to be fixed. > > Thanks, > Ethan Feng. > > rexxiong <[email protected]> 于2023年12月22日周五 11:35写道： >> >> +1 (binding) >> I checked >> - Download links are valid. >> - git commit hash is correct >> - Checksums and signatures are valid. >> - No binary files in the source release >> - Files have the word incubating in their name. >> - DISCLAIMER,LICENSE and NOTICE files exist. >> - Successfully built the binary from the source on MacOs with Command: >> ./build/make-distribution.sh -Pspark-3.3 >> >> Thanks, >> Jiashu Xiong >> >> Nicholas Jiang <[email protected]> 于2023年12月22日周五 11:05写道： >> >>> +1 (non-binding) >>> >>> I checked >>> - Download links are valid. >>> - Checksums and signatures are valid. >>> - Git commit hash is correct >>> - No binary files in the source release >>> - Files have the word incubating in names. >>> - DISCLAIMER,LICENSE and NOTICE files exist. >>> - Successfully built the binary from the source via command: >>> ./build/make-distribution.sh --release >>> >>> Regards, >>> Nicholas Jiang >>> >>> On 2023/12/21 13:41:36 Fu Chen wrote: >>>> Hi Celeborn community, >>>> >>>> This is a call for a vote to release Apache Celeborn (Incubating) >>>> 0.4.0-incubating-rc0 >>>> >>>> >>>> The git tag to be voted upon: >>>> >>> https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc0 >>>> >>>> >>>> The git commit hash: >>>> de6d8d69af3381ee899ba8d92c5d63b332cbdfbf source and binary artifacts can >>> be >>>> found at: >>>> >>> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc0 >>>> >>>> >>>> The staging repo: >>>> >>> https://repository.apache.org/content/repositories/orgapacheceleborn-1046 >>>> >>>> >>>> Fingerprint of the PGP key release artifacts are signed with: >>>> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B >>>> >>>> >>>> My public key to verify signatures can be found in: >>>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS >>>> >>>> >>>> The vote will be open for at least 72 hours or until the necessary >>>> number of votes are reached. >>>> >>>> >>>> Please vote accordingly: >>>> >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove (and the reason) >>>> >>>> >>>> Checklist for release: >>>> >>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >>>> Steps to validate the release: >>>> https://www.apache.org/info/verification.html >>>> >>>> >>>> * Download links, checksums and PGP signatures are valid. >>>> * Source code distributions have correct names matching the current >>> release. >>>> * Release files have the word incubating in their name. >>>> * DISCLAIMER, LICENSE and NOTICE files are correct. >>>> * All files have license headers if necessary. >>>> * No unlicensed compiled archives bundled in source archive. >>>> * The source tarball matches the git tag. >>>> * Build from source is successful. >>>> >>>> Please be aware that there has been a transition in the Celeborn >>> project's >>>> build tool, shifting from Maven to SBT. The SBT build documentation is >>>> available >>>> at https://celeborn.apache.org/docs/latest/developers/sbt/. >>>> >>>> For illustrative purposes: >>>> >>>> Packaging the project >>>> ``` >>>> ./build/sbt clean package >>>> ``` >>>> >>>> Creating the distribution >>>> ``` >>>> ./build/make-distribution.sh --sbt-enabled --release >>>> ``` >>>> >>>> Thanks, >>>> Fu Chen >>>> >>>
