-1 because of the license issue. The non-fat jar (e.g. celeborn-worker_2.12-0.4.0-incubating.jar) should also ship the NOTICE and LICENSE file, usually under the root folder or META-INF.
Thanks, Cheng Pan On Mon, Dec 25, 2023 at 1:10 PM Shaoyun Chen <[email protected]> wrote: > > +1 (non-binding) > > I checked the following things: > > - signatures are good. > ``` > gpg --import KEYS > gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc > gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc > ``` > - checksums are good. > ``` > sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512 > sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512 > ``` > - build success from source code. > ``` > ./build/make-distribution.sh --release > ./build/make-distribution.sh --sbt-enabled --release > ``` > time > ``` > ./build/make-distribution.sh --release 1779.60s user 89.17s system > 311% cpu 10:00.60 total > ``` > ``` > ./build/make-distribution.sh --sbt-enabled --release 893.63s user > 40.47s system 361% cpu 4:18.59 total > ``` > > Yihe Li <[email protected]> 于2023年12月25日周一 11:48写道： > > > > +1 (non-binding) > > I checked the following things: > > - git commit hash is correct. > > - download links are valid. > > - release files are in correct location. > > - release files have the word incubating in their name. > > - signatures and checksums are good. > > - DISCLAIMER, LICENSE and NOTICE files exist. > > - build success from source code(ubuntu 16.04). > > ``` > > ./build/make-distribution.sh --release > > ./build/make-distribution.sh -Pspark-3.3 > > ``` > > > > Thanks, > > Yihe Li > > > > On 2023/12/25 02:15:00 Ethan Feng wrote: > > > +1(binding) > > > > > > I checked: > > > √ release files in the correct location > > > √ release files have the word incubating > > > √ digital signature and hashes correct > > > √ DISCLAIMER file exist > > > √ LICENSE and NOTICE files exist and are correct > > > √ the contents of the release match the tag in VCS > > > √ can build the release from the source > > > √ maven artifacts look correct > > > > > > > > > Thanks, > > > Ethan Feng > > > > > > Fu Chen <[email protected]> 于2023年12月23日周六 00:05写道： > > > > > > > > Hi Celeborn community, > > > > > > > > This is a call for a vote to release Apache Celeborn (Incubating) > > > > 0.4.0-incubating-rc1 > > > > > > > > > > > > The git tag to be voted upon: > > > > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc1 > > > > > > > > > > > > The git commit hash: > > > > 6efa068c6715e80e4ddee6bc37d6aaf5bf5251fa source and binary artifacts > > > > can be > > > > found at: > > > > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc1 > > > > > > > > > > > > The staging repo: > > > > https://repository.apache.org/content/repositories/orgapacheceleborn-1047 > > > > > > > > > > > > Fingerprint of the PGP key release artifacts are signed with: > > > > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B > > > > > > > > > > > > My public key to verify signatures can be found in: > > > > https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS > > > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > > > number of votes are reached. > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and the reason) > > > > > > > > > > > > Checklist for release: > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > Steps to validate the release: > > > > https://www.apache.org/info/verification.html > > > > > > > > > > > > * Download links, checksums and PGP signatures are valid. > > > > * Source code distributions have correct names matching the current > > > > release. > > > > * Release files have the word incubating in their name. > > > > * DISCLAIMER, LICENSE and NOTICE files are correct. > > > > * All files have license headers if necessary. > > > > * No unlicensed compiled archives bundled in source archive. > > > > * The source tarball matches the git tag. > > > > * Build from source is successful. > > > > > > > > Please be aware that there has been a transition in the Celeborn > > > > project's > > > > build tool, shifting from Maven to SBT. The SBT build documentation is > > > > available > > > > at https://celeborn.apache.org/docs/latest/developers/sbt/. > > > > > > > > For illustrative purposes: > > > > > > > > Packaging the project > > > > ``` > > > > ./build/sbt clean package > > > > ``` > > > > > > > > Creating the distribution > > > > ``` > > > > ./build/make-distribution.sh --sbt-enabled --release > > > > ``` > > > > > > > > Thanks, > > > > Fu Chen > > >
