+1 (binding)

I checked
- git commit hash is correct.
- links are valid.
- signatures are good.
```
gpg --verify apache-celeborn-0.5.0-bin.tgz.asc apache-celeborn-0.5.0-bin.tgz
gpg --verify apache-celeborn-0.5.0-source.tgz.asc
apache-celeborn-0.5.0-source.tgz
```
- checksums are good.
```
shasum -a 512 apache-celeborn-0.5.0-bin.tgz
shasum -a 512 apache-celeborn-0.5.0-source.tgz
```

- build success from source code (macOS).

```
./build/make-distribution.sh -Pspark-3.4
```

Thanks,
Kerwin Zhang

Fu Chen <[email protected]> 于2024年6月24日周一 14:46写道:
>
> +1
>
> I checked
> - download links are valid.
> - git commit hash is correct.
> - no binary files in the source release.
> - build success from source code (JDK 17).
> ```
> ./build/make-distribution.sh --sbt-enabled -Pspark-3.5
> ```
>
> Cheng Pan <[email protected]> 于2024年6月24日周一 14:09写道:
> >
> > +1 (binding)
> >
> > - All links are valid.
> > - LICENSE/NOTICE looks fine.
> > - CI result looks great.
> > - No known blockers.
> >
> > Thanks,
> > Cheng Pan
> >
> >
> > > On Jun 19, 2024, at 12:45, Ethan Feng <[email protected]> wrote:
> > >
> > > Hello, Celeborn community,
> > >
> > > This is a call for a vote to release Apache Celeborn
> > > 0.5.0-rc3
> > >
> > > The git tag to be voted upon:
> > > https://github.com/apache/celeborn/releases/tag/v0.5.0-rc3
> > >
> > > Source and binary artifacts can be found at:
> > > https://dist.apache.org/repos/dist/dev/celeborn/v0.5.0-rc3
> > >
> > > The git commit hash:
> > > 048ef207359113247bff05dcc203c70021ccfa10
> > >
> > > The staging repo:
> > > https://repository.apache.org/content/repositories/orgapacheceleborn-1076/
> > >
> > > The fingerprint of the PGP key release artifacts is signed with:
> > > FCF20BB29C7BEFDF58F998F76392F71F37356FA0
> > >
> > > My public key to verify signatures can be found in:
> > > https://dist.apache.org/repos/dist/release/celeborn/KEYS
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> > > number of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and the reason)
> > >
> > > Steps to validate the release:
> > > https://www.apache.org/info/verification.html
> > >
> > > * Download links, checksums, and PGP signatures are valid.
> > > * Source code distributions have correct names matching the current 
> > > release.
> > > * LICENSE and NOTICE files are correct.
> > > * All files have license headers if necessary.
> > > * No unlicensed compiled archives bundled in the source archive.
> > > * The source tarball matches the git tag.
> > > * Build from source is successful.
> > >
> > > There are additional tests:
> > > * Performance test no regression
> > > 1 TB TPC-DS, 0.5.0 VS 0.4.1 : 2042(s) VS 2050(s)
> > > 1.1 TB pure shuffle, 0.5.0 VS 0.4.1 : 11.8min vs 11.8min
> > >
> > > * Result correctness test passed
> > > 1TB TPC-DS runs concurrently, the results are identical.
> > >
> > > * Usability test passed
> > > Rolling upgrade from version 0.4.1 to 0.5.0 succeed.
> > > The metrics system works as expected.
> > >
> > > * Stability test passed
> > > Random worker failures, Celeborn works as expected.
> > > Random master failures, Celeborn works as expected.
> > > Master meta corrupted, Celeborn works as expected.
> > >
> > > * Compatibility test passed
> > > The Celeborn server version of 0.5.0 works fine with the Celeborn client 
> > > 0.4.1.
> > >
> > > * Grafana dashboard layout checked
> > >
> > >
> > > Regards,
> > > Ethan Feng
> >

Reply via email to