Thanks for creating an issue. I've been looking at the patch a bit, and noticed you enabled all warnings. While I think this is a good idea, I've created a separate issue for it [1]. Normally I prefer patches for 1 module, yours included a few fixed for files not related to the echo example as well. I will commit those fixes under the issue at [1].
Is the "-pthread" needed on Linux? I haven't had any problems on OSX without it, and do get a warning when using it. If it is needed an extra check is needed to not use it on OSX, but for other UNIXes. Ps: You also included a patch file in the patch, I assume this was not intentional, and just ignored the file. Pps: I also updated the ident of the echo_client to a better suited text (sorry, couldn't resist :)). [1]: https://issues.apache.org/jira/browse/CELIX-156 2014-09-28 22:04 GMT+02:00 Erjan Altena (JIRA) <[email protected]>: > > [ > https://issues.apache.org/jira/browse/CELIX-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Erjan Altena updated CELIX-154: > ------------------------------- > Description: > The echo echo-example was not working. I made a fix. It does not rely any > more an apr but on posix threads. > > I added also a small error message fix and enabled compiler warnings. > > The attached patch is based on the current trunk. If you lke to have it > in another format please let me know. > > was: > The echo echo-example was not working. I made a fix. It does not rely any > more an apr but on posix threads. > > I added also a small error message fix and enabled compiler warnings. > > The fix is a patcn on current trunk. If you lke to have it in another > format please let me know. > > > > echo exampe not working > > ----------------------- > > > > Key: CELIX-154 > > URL: https://issues.apache.org/jira/browse/CELIX-154 > > Project: Celix > > Issue Type: Bug > > Components: Examples > > Affects Versions: next-incubating > > Environment: linux 32 bit > > Reporter: Erjan Altena > > Priority: Minor > > Fix For: next-incubating > > > > Attachments: echo_example_fix.patch > > > > > > The echo echo-example was not working. I made a fix. It does not rely > any more an apr but on posix threads. > > I added also a small error message fix and enabled compiler warnings. > > The attached patch is based on the current trunk. If you lke to have it > in another format please let me know. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Met vriendelijke groet, Alexander Broekhuis
