Hello, Luckely point 3 was my mistake. I did not start etcd. Thanks Gabriele.
So [+1] On Mon, Jan 29, 2018 at 8:07 AM, Gerrit Binnenmars < [email protected]> wrote: > Hello, > > Good to see the voting for a new Celix release. > > I have some remarks: > > 1. nice to have: > If I run ccmake .. some warnings appear. It would be good if the > documentation would indicate this. > *maintain@localhost:/opt/github/celix/celix-2.1.0/build$ cmake ..* > *-- Using zip to create bundles* > *-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) * > *-- Could NOT find CPPUTEST (missing: CPPUTEST_LIBRARY > CPPUTEST_INCLUDE_DIR) * > *-- Could NOT find CPPUTEST_EXT (missing: CPPUTEST_EXT_LIBRARY > CPPUTEST_EXT_INCLUDE_DIR) * > *-- Could NOT find CPPUTEST (missing: CPPUTEST_LIBRARY > CPPUTEST_INCLUDE_DIR) * > *-- Could NOT find CPPUTEST_EXT (missing: CPPUTEST_EXT_LIBRARY > CPPUTEST_EXT_INCLUDE_DIR) * > *-- Configuring done* > *-- Generating done* > *-- Build files have been written to: /opt/github/celix/celix-2.1.0/build* > > > > *2. pubsub shall be added to the documents/subprojects* > > *3. On my system the pubsub subscriber is not receiving data (or only > initially??)* > *maintain@localhost:/opt/github/celix/celix-2.1.0/build/deploy/pubsub/pubsub_subscriber_udp_mc$ > sh run.sh* > *-> PSD: Using discovery HOST:PORT: 127.0.0.1:2379 <http://127.0.0.1:2379>* > *PSD: pubsub_tm_announce_publisher added.* > *IP Detected : 127.0.0.1* > *PSA_UDP_MC: json serializer added* > *Score for pair <udp_mc,json> = 65.000000* > *PSA_UDP_MC: Received subscription > [FWUUID=64ff2b13-62c2-44f2-8f65-dbebc528e001 bundleID=17 scope=default, > topic=poi1]* > *Score for pair <udp_mc,json> = 65.000000* > *PSA_UDP_MC: Received subscription > [FWUUID=64ff2b13-62c2-44f2-8f65-dbebc528e001 bundleID=18 scope=default, > topic=poi2]* > *Subscriber started...* > *Launcher: Framework Started* > > > > *4. The roadmap.md <http://roadmap.md> file shall be updated because the > work is now partly realised* > > > *5. Was the documents folder already available in the 2.0 release, > otherwise add it to the Changes.md* > > *Because there is done so much good work in this release I don't want to > vote negatively, but point 3 is in my opinion quite serious. Could one of > the other voters please check if it the pubsub example runs?* > > > *Greetings Gerrit* > > > > On Sun, Jan 28, 2018 at 5:04 PM, Bjoern Petri <[email protected]> > wrote: > >> >> +1 (binding) >> >> >> I identified some minor issues, but none of them are sufficient serious >> to block the release: >> >> - android docker build seems to be broken due to zlib dependency >> - NOTICE year needs update >> >> Besides, I checked that signature+hashes are correct using >> the keys from https://dist.apache.org/repos/dist/dev/celix/KEYS . >> >> >> Regards, >> Bjoern >> >> >> On 24.01.2018 14:30, Pepijn Noltes wrote: >> > Hi All, >> > >> > This is the release vote for Apache Celix, version 2.1.0 >> > >> > This release contains various bug fixes and adds a service-based >> > publish subscribe implementation. >> > For a complete overview see: >> > https://github.com/apache/celix/blob/353ac0d2e0f819f8f59d4cd >> f8ea1dfd701201d74/CHANGES.md >> > >> > >> > Source files: >> > https://dist.apache.org/repos/dist/dev/celix/celix-2.1.0/ >> > >> > The commit ID to be voted upon: >> > 353ac0d2e0f819f8f59d4cdf8ea1dfd701201d74 >> > >> > https://github.com/apache/celix/tree/353ac0d2e0f819f8f59d4cd >> f8ea1dfd701201d74 >> > >> > Celix's keys can be found at: >> > https://dist.apache.org/repos/dist/dev/incubator/celix/KEYS >> > >> > >> > Information for voting on a release can be found at >> > http://www.apache.org/dev/release.html#approving-a-release >> > >> > Please vote to approve this release: >> > [ ] +1 Approve the release >> > [ ] -1 Disapprove the release (please provide specific comments) >> > >> > Note that an Apache release needs to be a Majority Approval (requires >> > at-least 3 binding +1 votes and more +1 votes than -1 votes). >> > >> > If this release is approved I will promote it to an official release >> > (e.g. move from dist/dev to dist/release and tagging the release in git) >> > >> > This vote will be open for at least 72 hours. >> > >> > Greetings, >> > Pepijn >> >> >> >
