rlenferink commented on issue #39: Added pubsub admin websocket
URL: https://github.com/apache/celix/pull/39#issuecomment-519526567
 
 
   Hi @dhbfischer. Thanks for yet another code donation. I've reviewed this 
contribution and it looks good to me. It is building and tests are running as 
well (1 test is failing but that is in another component and was failing before 
this PR as well).
   
   Because this is a new component and a substantial contribution we need to do 
a vote on our dev@celix mailing list. After that we also need to go through the 
formal IP clearance process to ensure that proper attention is paid to 
intellectual property.
   
   I will start a formal vote on the dev@celix mailing list on accepting this 
code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to