rlenferink commented on a change in pull request #48: Feature/pubsub tcp admin
fix
URL: https://github.com/apache/celix/pull/48#discussion_r322751349
##########
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c
##########
@@ -451,7 +451,8 @@ void pubsub_tcpHandler_setUrlInfo(char *url,
pubsub_tcpHandler_url_t *url_info)
url_info->hostname = strtok(strdup(hostname), ":");
if (port) {
port += 1;
- if (isdigit(atoi(port)) == 0) url_info->portnr = atoi(port);
+ unsigned int portDigits = (unsigned) atoi(port);
Review comment:
Probably the cast should be `(unsigned int)` as well (right now
`(unsigned)`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
