Oipo commented on a change in pull request #139: Add parsing of version and filter on version when calling useService*. URL: https://github.com/apache/celix/pull/139#discussion_r365989053
########## File path: libs/framework/src/service_tracker.c ########## @@ -32,6 +32,8 @@ #include "celix_log.h" #include "bundle_context_private.h" #include "celix_array_list.h" +#include "../../utils/src/version_range_private.h" Review comment: While I agree that including private headers is nasty, the source code in service_tracker.c needs the full definition of the structs in those headers, otherwise it simply does not compile. Would you be ok with removing the private header files and moving the definitions of the structs into version_range.h? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
